Open pthomas opened 4 years ago
@pthomas a screenshot is always very nice to start the review, as requested in the PR template.
By the way, have you scripted the footprint ? You should. Post a link here to the generator PR if it was done.
Joel
HI Joel,
On Fri, Sep 25, 2020 at 7:54 AM Joel notifications@github.com wrote:
@pthomas https://github.com/pthomas a screenshot is always very nice to start the review, as requested in the PR template.
By the way, have you scripted the footprint ? You should. Post a link here to the generator PR if it was done.
I'll add screenshots next time. The footprints were just made with the built-in 'Ball Grid Array Footprint Wizard'.
-Paul
@chschlue following comment "The footprints were just made with the built-in 'Ball Grid Array Footprint Wizard'.", is it the correct way to generate BGA fp ? Thanks
Thanks @chschlue @pthomas you should use the generator indicated above.
On Mon, Sep 28, 2020 at 12:58 PM Joel notifications@github.com wrote:
Thanks @chschlue https://github.com/chschlue @pthomas https://github.com/pthomas you should use the generator indicated above.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-footprints/pull/2489#issuecomment-700158810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDP5OFKRGWHLIEDOA5WVLSIC6BXANCNFSM4RY2PIIQ .
OK, I recently ran across that for creating an asymmetric pitch package. So should I submit a pull request against bga.yaml?
It might be nice if the preferred tool were the one actually included in kicad?
-Paul
You should submit a pull request on the footprint generator git and update this PR with the generated footprint. The generator is not integrated in KiCad, but maybe one day, who knows ? :)
So should I submit a pull request against bga.yaml?
Yes, please.
It might be nice if the preferred tool were the one actually included in kicad?
Theoretically yes, and the generator is going to become part of the KiCad project instead of being a third party repo, but actually including it in the application is not quite so easy, we would still need some procedure to add size definitions to the repo for example.
Note that the two generators work differently. The one internal to KiCad lets you directly specify a footprint you desire (arranging pads in arrays and such in the process) while the one used for library additions lets you specify a package, auto-generating IPC 7351 compliant footprints for it. This means the latter is vastly superior for creating general purpose footprints for use in an included library.
On Mon, Sep 28, 2020 at 1:14 PM Christian Schlüter notifications@github.com wrote:
So should I submit a pull request against bga.yaml?
Yes, please.
OK, I put it in: https://github.com/pointhi/kicad-footprint-generator/pull/644
If the naming & everything are OK I'll update the kicad-footprints pull request, and as the names are in the symbols that as well.
thanks, Paul
@pthomas adding the footprint here at the same time is also a great benefit for the reviewer...
On Tue, Sep 29, 2020 at 9:47 AM Joel notifications@github.com wrote:
@pthomas adding the footprint here at the same time is also a great benefit for the reviewer...
OK, just wanted to make sure the names were OK: Microchip_FCVG484_19x19mm_Layout22x22_P0.8mm Microchip_FCG1152_35x35mm_Layout34x34_P1.0mm
I wasn't sure about the Microchip prefix and the FCVG & FCG as opposed to just 'BGA-'? If the names are fine I'll submit everything.
-Paul
I think it's not bad, but just to be sure: you have not to rename the parts. You should push here the exact result of the script.
OK, kicad-symbols and kicad-footprints are both updated in my repos. The kicad-footprints is exactly what the script generated.
-Paul
On Wed, Sep 30, 2020 at 2:56 AM Joel notifications@github.com wrote:
I think it's not bad, but just to be sure: you have not to rename the parts. You should push here the exact result of the script.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-footprints/pull/2489#issuecomment-701197950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDP5MY3CJUHHSS7YZTDVLSILJBTANCNFSM4RY2PIIQ .
@pthomas one question here:
Joel
On both parts a Solder mask clearance of 0.015mm is defined per the packaging guide.
Both were generated with the Ball Grid Array Footprint Wizard
These footprints are defined here: https://www.microsemi.com/document-portal/doc_download/1244577-ug0902-polarfire-soc-fpga-packaging-and-pin-descriptions-user-guide
These are the two packages Microchip has provided for the PolarFire SoC's, the symbol pull request can be viewed here: https://github.com/KiCad/kicad-symbols/pull/2843
:warning: Deprecation warning
On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by
kicad-bot
(importer documentation).All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)