search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
127 stars 95 forks source link

F6.3 & F7.4: Improper handling of custom mask/paste pads and thermal vias #245

Open evanshultz opened 6 years ago

evanshultz commented 6 years ago

We are using custom mask and paste pads as needed. Right now, this often generates a lot of noise because the footprint is constructed as desired but warnings and/or errors are generated.

Also, we have decided not to turn on mask for thermal vias and this violates the scripts' expectation for through holes. See https://github.com/KiCad/kicad-footprints/pull/285.

These are two separate issues, but they often come together in the same footprints so I've joined them.

See https://github.com/KiCad/kicad-footprints/pull/679 for one example. Here is the output from one footprint: image

poeschlr commented 4 years ago

One simple way out would be to ignore this single rule if the footprint name has the suffix ThermalVias. Even better would be an additional check if the pad number matches a smd pad. Would this be acceptable as i think this would be easy to implement.

poeschlr commented 4 years ago

Ok there already is a pull request for adding a proper fix: https://github.com/KiCad/kicad-library-utils/pull/288