search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

Silk, pad overlap seems to be unreliable #254

Open poeschlr opened 6 years ago

poeschlr commented 6 years ago

I did not yet find time to investigate this in more detail. It reported an overlap between silk an pad in this PR even thought the effected pads have clearance between silk and pads. https://github.com/KiCad/kicad-footprints/pull/839

zgyarmati commented 5 years ago

This one also hit me, but from a different angle, on my footprint the script didn't report the overlap between the silkscreen and the pad, see here: https://github.com/KiCad/kicad-footprints/pull/1558#issuecomment-486897238 See this version of the footprint in question: https://github.com/KiCad/kicad-footprints/blob/e52d325004eb2c6c4035ef20e5efcefed5f1e4a9/Connector_BarrelJack.pretty/BarrelJack_Lumberg_1613-14_15_SMT_Horizontal.kicad_mod

I started to look into the pcb/rules/F5_1.py' checkIntersections method, but before diving into it too deep, i need to ask: Would it be possible to depend on external libs in the scriptset? For the intersection checking (but i think also at other places in the scripts) it would be handy to use shapely ( https://pypi.org/project/Shapely/ ) or other geometric lib.

evanshultz commented 5 years ago

I think, at this time, we'd prefer to limit dependencies. Do you have some suggestions without adding any? If you feel the checking for this rule, at least, cannot be substantially or easily improved without adding an external lib then that is good info to share with us as well.