search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

correct spelling in interface to KiCadSymbolGenerator #261

Closed dlharmon closed 5 years ago

dlharmon commented 5 years ago

I'm looking to add a few scripts using this and don't want to propagate it further.

evanshultz commented 5 years ago

@poeschlr @Ratfink Can you take a look? I think you two wrote these.

Why is there a note that the typo must be kept? Is there an external data file (YAML?) that also has the typo? Can they both be fixed together?

Ratfink commented 5 years ago

The note about the typo in the STM32 symbol generator was because I didn't want to change more than necessary in the PR that updated that script. If this correctly changes every occurrence of the typos, both in the package they're defined in and everything that uses it, it should be good. I haven't looked closely to see if this is in fact the case though.

dlharmon commented 5 years ago

I've found another I'd like to fix (Aligment) and pushed it to this branch.

There's also a place where Horizontal and Vertical appear to be swapped which I need to investigate further.

I've verified all are changed in this repository. Any others I should be aware of?

SchrodingersGat commented 5 years ago

Thanks @dlharmon for these fixes