KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 92 forks source link

G1.7 should produce an error, not a warning #273

Closed fauxpark closed 5 years ago

fauxpark commented 5 years ago

The wording of this rule "must always" suggests that this check should error out if it encounters a file with CRLF line endings. The .gitattributes file should catch most of these by automatically converting to LF during the commit, but apparently it does not apply when committing through the browser.

The unfortunate part is that when working on Windows, running the check before committing will show this error, but provided there are no other issues flagged you can just commit anyway and reset your working tree.

poeschlr commented 5 years ago

Thanks