Closed ObKo closed 4 years ago
Just looking at the code it looks good to me. Thanks!
@evanshultz i assume you simply forgot to merge this after thanking the contributor. I took a short look and could not find anything wrong with it so i will merge it now. @ObKo thanks again and sorry for this mishap.
This PR fix issue found during work at https://github.com/KiCad/kicad-library-utils/pull/293
Current script checks symbol origin using pins and rectangles regardless of unit they belongs to. This leads to false rule violation for symbols which have multiple units with different drawing/pins.
New version of script process units individually if symbol has multiple units and "units_locked" flag.