Fix S3.1 checker for multi-unit symbols.

KiCad / kicad-library-utils

Some scripts for helping with library development

GNU General Public License v3.0

128 stars 95 forks source link

Fix S3.1 checker for multi-unit symbols. #299

Closed ObKo closed 4 years ago

ObKo commented 5 years ago

This PR fix issue found during work at https://github.com/KiCad/kicad-library-utils/pull/293

Current script checks symbol origin using pins and rectangles regardless of unit they belongs to. This leads to false rule violation for symbols which have multiple units with different drawing/pins.

New version of script process units individually if symbol has multiple units and "units_locked" flag.

evanshultz commented 5 years ago

Just looking at the code it looks good to me. Thanks!

poeschlr commented 4 years ago

@evanshultz i assume you simply forgot to merge this after thanking the contributor. I took a short look and could not find anything wrong with it so i will merge it now. @ObKo thanks again and sorry for this mishap.