KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

travis git diff behaves strangely for pull requests based on old common commits #302

Open poeschlr opened 5 years ago

poeschlr commented 5 years ago

Our syntax that should ensure only additions by the contributor are checked seems to fail lately. Travis git diff with three dots gets the same result as with two dots. If i do the same locally then three dots gets us what we want to see and two dots behaves like travis does.

See:

effected footprints (examples):


For reference this is how git diff should behave: img


This states that triple dot diff does not always work nicely could contain hints: https://stackoverflow.com/questions/51618951/git-diff-check-shows-changes-of-unrelated-branch-files