search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

Check symbol for duplicate graphic elements (#37) #303

Open cpresser opened 5 years ago

cpresser commented 5 years ago

Introduce new rule S3.9 to check if the symbol has duplicate graphical elements.

This implements the 'SIMPLE' approach mentioned here: See https://github.com/KiCad/kicad-library-utils/issues/37

So far there is no 'written' Rule for KLC yet. If there is some positive feedback for this patch, I can create a PR for that as well.

ghost commented 4 years ago

see https://github.com/KiCad/kicad-symbols/pull/2267

poeschlr commented 4 years ago

The new rule S3.9 would need to be added to the website. Please open a pull request over at the website repo (still on github as far as i know) and link between the two

cpresser commented 4 years ago

Here is the PR for the website: https://github.com/KiCad/kicad-website/pull/475

cpresser commented 4 years ago

Thanks for the review, those were all valid points with really help full recommendations. :+1: And sorry for the huge delay - this PR somehow slipped my attention.

cpresser commented 4 years ago

The Website-Merge-Request now lives here: https://gitlab.com/kicad/services/kicad-website/-/merge_requests/475