search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

S4.3 pin stacking not reliable enough #308

Open karlp opened 5 years ago

karlp commented 5 years ago

It isn't reliable enough to be considered a "failure" (yet?) so it's not looked at by submitters, "all checks are green" And when you do read the suggestions, it just says, "power in/out should not be invisible" It doesn't mention the other option, "should this pin be passive?"

https://github.com/KiCad/kicad-library-utils/blob/master/schlib/rules/S4_3.py#L135 is correctly idenfitying the "power in/out+passive" stack that's required, when it's correct, but it doesn't suggest it as a solution when it's wrong.

poeschlr commented 5 years ago

Was the invisible power input pin already stacked? Because that is the only case where we could make this suggestion. If it is not stacked then the error is that it is invisible. If it is stacked then the error is that it has potentially the wrong type.

karlp commented 5 years ago

yes, because I'd attempted to get the stack right.