search

KiCad / kicad-library-utils

Some scripts for helping with library development
GNU General Public License v3.0
128 stars 95 forks source link

Update metadatacheck to fit v5.1 #312

Open poeschlr opened 4 years ago

poeschlr commented 4 years ago

klc update https://github.com/KiCad/kicad-website/pull/446

evanshultz commented 4 years ago

I assume at https://github.com/KiCad/kicad-website/pull/446#issuecomment-575893024 you are referring to this script update?

check_lib_file requires at least four pieces of documentation in the lib file. Isn't that wrong? Don't we want F4 to always be blank, and we also accept F3 to be blank for generic symbols that only have a bunch of FP filters? Maybe I didn't quite understand this.

poeschlr commented 4 years ago

I now ran the new script and old script on the current master branch of the symbol lib (Limited to the rules that i changed). There is not really a difference in the reports other than what is expected from combining the rules (S6.3 changed to S6.2, detailed messages changed and if both s6.3 and S6.2 is violated then they are of course under the same header which makes diff think something was added in the original) The logs i created in this process: before_change_1.txt after_change_1.txt