search

KiCad / kicad-library

The schematic and 3D libraries for KiCad 4.0. Note that the footprint libraries are the *.pretty repos themselves. This is an orphaned repo, the news about the v5 libs, http://kicad.org/post/kicad-official-libraries/.
Other
746 stars 956 forks source link

Incorrect pin electrical type on 74LS30. #1787

Closed 117L7 closed 6 years ago

117L7 commented 6 years ago

The 74LS30 from the 74xx library has the output pin (8) marked as an input pin. This causes ERC failures.

KiCad 4.0.7 for OS X.

SchrodingersGat commented 6 years ago

@117L7 can you submit a PR to address this issue? This will be the quickest path to fixing :)

117L7 commented 6 years ago

Sure, how would I do that?

SchrodingersGat commented 6 years ago

http://kicad-pcb.org/libraries/contribute/

If this all seems too much for you, perhaps someone will have time to make the fix for you.. But, if you are willing to learn, extra contributors are always welcomed!

bobc commented 6 years ago

I think I already fixed this. Did you check the latest version of Logic_74xx ? It looks correct to me.

https://github.com/KiCad/kicad-library/blob/master/library/Logic_74xx.lib#L3341

117L7 commented 6 years ago

I downloaded kicad-library-master, it looks like the libraries have been reorganized compared to the 4.0.7 distribution.

I'll give Logic_74xx a try later today.

On Thu, Nov 2, 2017 at 3:42 AM, Bob Cousins notifications@github.com wrote:

I think I already fixed this. Did you check the latest version of Logic_74xx ? It looks correct to me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-library/issues/1787#issuecomment-341382456, or mute the thread https://github.com/notifications/unsubscribe-auth/AfwRre9eAUIlopVq7QcuFEkhI_c1QUjDks5syZyngaJpZM4QOzLQ .

poeschlr commented 6 years ago

Yes we have already started the preperation for the v5 release. You might want to use some older commit. @jkriege2, @SchrodingersGat should we tag the last commit before we started with the reorganization?

117L7 commented 6 years ago

I tried Logic_74xx, but the problem now is the symbols are a smaller size (which is a good thing), and the shrinkage apparently caused all the devices to disconnect from the nets. I didn't expect this would happen.

I uploaded some screen shots before/after, from the original 2 to now 299 ERC errors, so the testing is inconclusive.

I was able to restore by removing the library and using the schematic redraw button.

screen shot 2017-11-02 at 11 23 33 am screen shot 2017-11-02 at 11 28 08 am

poeschlr commented 6 years ago

Not only the size did change. We also moved the power pins to a separate unit. (They where invisible pins placed at every unit in the old lib.) Edit: this means the power pins would be missing if one would update the symbols. And ERC will not complain about it!

This is why we will release this stuff only for the v5 release. Users will expect massive changes on a major release so the surprise will not be that bad.

poeschlr commented 6 years ago

If the electrical types are still wrong please reopen this over at https://github.com/KiCad/kicad-symbols. Regarding recising: you will need to accept these changes as the new lib is intended for a new major release and we allow major changes there. We will try to keep the lib as stable as possible during the next stable release cycle.