search

KiCad / kicad-library

The schematic and 3D libraries for KiCad 4.0. Note that the footprint libraries are the *.pretty repos themselves. This is an orphaned repo, the news about the v5 libs, http://kicad.org/post/kicad-official-libraries/.
Other
746 stars 956 forks source link

Move opto gate drivers to driver_mosfet #1789

Closed El3ctr0nic closed 6 years ago

El3ctr0nic commented 6 years ago

Some tweaks and unification on symbols move.

El3ctr0nic commented 6 years ago

opto_move

Ok some Jenskins fail so i must repair it :) Be patient :)

El3ctr0nic commented 6 years ago

I have some issue with new KLC. Power pins should be placed top/bottom of the symbol. It make some complications in dual isolated gate drivers. Connection will be totally unlogical (personal opinion). I think best way is setup power pins as OC and OE to pass Jenkins. Dual driver example below. Making splitted symbol isn't good idea too. In drivers logic and physic connection is very close (3-phase bridges).

acpl314

Same problem appear on TI UCC series. Maybe we need to discuss this rule again? In some cases it made schematic very "ugly" I think. Lot of cross wires in chierarchic sheet where we have only driver and MOSFET/IGBT. Eclipse :) Symbols should be smalest as possible but in evry case?

For comparision previous IRS symbol and now. Will be schematic look good as befor after replace? irs

I need some opinion to continue my work :) Regards Marcin

El3ctr0nic commented 6 years ago

I resized LTV temporary to pass Jenskins (i think it should be splitted symbol). I made some cheat in drivers. Shared output transistors and uses underscore before pin names (VCC, VDD) to pass check. Outputs type updated to output, before passive pins. Links for doc updated to Broadcom site. Pls feedback :) Regards Marcin

SchrodingersGat commented 6 years ago

@El3ctr0nic thanks for the contribution, sorry that it has not had a response yet.

Firstly, please note that the KLC is not always 100% right and there are exceptions. Please do not "cheat" by renaming the pins. In this case I think that the way that you have drawn these symbols is correct, and the warnings generated by KLC can be ignored.

Also, note that warnings are (generally speaking) associated with rules that say should instead of must (that's the idea, anyway).

So, please revert the pin names to their original form :)

SchrodingersGat commented 6 years ago

As we are now close to moving all the symbols to the new kicad-symbols repository, this PR will have to be reissued at https://github.com/kicad/kicad-symbols

Thanks for your contributions, and sorry for the inconvenience