KiCad / kicad-library

The schematic and 3D libraries for KiCad 4.0. Note that the footprint libraries are the *.pretty repos themselves. This is an orphaned repo, the news about the v5 libs, http://kicad.org/post/kicad-official-libraries/.
Other
745 stars 956 forks source link

Added BAS40-04, AD8591, AD8592, and AD8594 #1858

Closed FJRocha closed 6 years ago

FJRocha commented 6 years ago

Added BAS40-04 to the diode library, and AD8591, AD8592, and AD8594 to the "analog-devices" library.

Misca1234 commented 6 years ago

Hi

When adding symbols it is beneficial if you push some screen shoots as well, like in this push

https://github.com/KiCad/kicad-library/pull/1712

FJRocha commented 6 years ago

image

FJRocha commented 6 years ago

image

FJRocha commented 6 years ago

I think the library updates are ok, but I can't make them pass the Travis-ci check.

Does anyone know why this error keeps coming up in the Travis-ci check?: if line[0] in self._KEYS: IndexError: list index out of range

FJRocha commented 6 years ago

Closing this pull request to separate the pull requests of Diode from the Analog Devices libraries.

FJRocha commented 6 years ago

OK, I couldn't figure out how to split the pull request, so here I try again.

jkriege2 commented 6 years ago

@SchrodingersGat could you have a look at the script output?

Thanks, JAN

FJRocha commented 6 years ago

image

evanshultz commented 6 years ago

Opamps and comparators should go into linear.lib. Please make that change and then I will review.

FJRocha commented 6 years ago

@evanshultz, Moved the OpAmps to "liner.lib". All checks passed. ;-)

poeschlr commented 6 years ago

The linear lib will be transferred over to the new repo with PR https://github.com/KiCad/kicad-symbols/pull/116.

This means we can no longer accept this contribution in the legacy repo. So please re open this in the new repo https://github.com/KiCad/kicad-symbols. I think they need to be moved into Amplifier_Operational.lib

Sorry for the inconvenience.

SchrodingersGat commented 6 years ago

As we are now close to moving all the symbols to the new kicad-symbols repository, this PR will have to be reissued at https://github.com/kicad/kicad-symbols

Thanks for your contributions, and sorry for the inconvenience