search

KiCad / kicad-library

The schematic and 3D libraries for KiCad 4.0. Note that the footprint libraries are the *.pretty repos themselves. This is an orphaned repo, the news about the v5 libs, http://kicad.org/post/kicad-official-libraries/.
Other
745 stars 956 forks source link

Added fourth pin to MCP1825S #1875

Closed johnfwhitmore closed 6 years ago

johnfwhitmore commented 6 years ago

I originally contributed the MCP1825S Component by copying the MCP1826S regulator. There is however a fourth pin which I've added. If this is Acceptable I can make the change to MCP1826S.

screenshot from 2017-12-18 20-59-07

SchrodingersGat commented 6 years ago

Thanks :)

johnfwhitmore commented 6 years ago

Deadly! That was quick, thanks for that. I'll do the same to the MCP1826S

jkriege2 commented 6 years ago

Hmmm ... When reworking the regul.lib, I cleaned it up a bit: The MCP1825S explicitly has the footprint filter SOT?223*TabPin2*, which points to a SOT-223-footprint, where the tab (you pin ) is actually pin2, so this "fix" is unnecessary and breaks the function(!!!), as the footprint only has pins 1,2,3. Also with the third pin, this symbol does no longer fit the other footprints in the filter-list (TO-220 only has 3 pins!!!). So please revert this. Or split out the 3 package variants into single symbols and set the explicit and correct footprint for each!

Also: The two GND-pins should be stacked for a nicer style!

Best, JAN

SchrodingersGat commented 6 years ago

Ah Jan you are correct, good catch. I did not spot that you had set the footprint to one that already took this "missing" pin into account. I'll revert this change.

johnfwhitmore commented 6 years ago

Oops, sorry I'll add the various parts :-(

On Tue, 19 Dec 2017, 11:13 Oliver, notifications@github.com wrote:

Ah Jan you are correct, good catch. I did not spot that you had set the footprint to one that already took this "missing" pin into account. I'll revert this change.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-library/pull/1875#issuecomment-352718169, or mute the thread https://github.com/notifications/unsubscribe-auth/AOepUbRiPyYoQSvJvlW4wdNDsSokpriRks5tB5pSgaJpZM4RGEJ3 .