KiCad / kicad-mac-builder

The macOS V5+ KiCad builder and packager [moved to https://gitlab.com/kicad]
13 stars 6 forks source link

Mojave SDK #217

Closed sethhillbrand closed 5 years ago

sethhillbrand commented 5 years ago

Hi @adamwolf

I'm going to try to figure out what is breaking KiCad in the new Mojave this weekend unless you are already on it.

adamwolf commented 5 years ago

What's broken in it?

On Fri, Sep 28, 2018, 4:05 PM Seth Hillbrand notifications@github.com wrote:

Hi @adamwolf https://github.com/adamwolf

I'm going to try to figure out what is breaking KiCad in the new Mojave this weekend unless you are already on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/217, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYTvUA1iAqNYQnei4blAcgOu173baks5ufo8HgaJpZM4W_zPS .

adamwolf commented 5 years ago

Sorry, lemme be a bit more verbose :)

Hi Seth!

I am on Mojave, and I can both compile KiCad using kicad-mac-builder, and I can also run whatever version I had installed before I upgraded.

I opened KiCad.app, opened pcbnew, opened eeschema, opened some files, and things seem fine on my end.

I haven't run the full "packaging regression test". Before I do that, I'll download a recent nightly and see if it works...

On Fri, Sep 28, 2018 at 8:37 PM Adam Wolf adamwolf@feelslikeburning.com wrote:

What's broken in it?

On Fri, Sep 28, 2018, 4:05 PM Seth Hillbrand notifications@github.com wrote:

Hi @adamwolf https://github.com/adamwolf

I'm going to try to figure out what is breaking KiCad in the new Mojave this weekend unless you are already on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/217, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYTvUA1iAqNYQnei4blAcgOu173baks5ufo8HgaJpZM4W_zPS .

sethhillbrand commented 5 years ago

Honestly, I'm not 100% clear on that yet. We had a bug report that KiCad opened and then quickly closed when using Mojave the week before it was released. Then there were a couple more folks on Twitter saying the same thing this week. So this was perhaps a bad extrapolation (read: assumption!) on my part.

I just ran the upgrade overnight and am trying it out. So far, my experience is yours. No issues.

And don't I feel just a bit like Chicken Little.

If nothing breaks during your regressions, I'll send an update/all clear to the list.

sethhillbrand commented 5 years ago

Ah! Got one. V5.0, open eeschema, open pcbnew, switch canvas legacy->openGL->legacy a few times. But doesn't seem to happen with nightlies.

Anything in the regression tests?

adamwolf commented 5 years ago

Does that happen in 10.13?

I haven't been able to run the tests from the README yet, but I will be today.

Don't worry about potentially crying wolf on this :). I much prefer crying wolf to "let's just do it and be legends" :)

Thank you so much for helping with macOS stuff! Adam

On Sat, Sep 29, 2018, 10:05 AM Seth Hillbrand notifications@github.com wrote:

Ah! Got one. V5.0, open eeschema, open pcbnew, switch canvas legacy->openGL->legacy a few times. But doesn't seem to happen with nightlies.

Anything in the regression tests?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/217#issuecomment-425651904, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYaIcVq3no4TL-jQSebbGIS0rrH1jks5uf4xKgaJpZM4W_zPS .

sethhillbrand commented 5 years ago

I never noticed it in 10.13 but I never did this exact test. Can't go back and check either :(

I feel like there is a "Leeroy Jenkins!" reference to be added here but perhaps that has jumped the shark (Happy Days references never go out)

sethhillbrand commented 5 years ago

@adamwolf Spoke too soon.

Did you see https://bugs.launchpad.net/kicad/+bug/1795214 ?

I can recreate with the current 5.0 nightly from 9/28 but I can't when compiling my own under Mojave.

sethhillbrand commented 5 years ago

Additional Mojave issue from: https://bugs.launchpad.net/kicad/+bug/1799094

sethhillbrand commented 5 years ago

We may need to bite the bullet and release two packages for Mac. That is what x2Go ended up doing (https://code.x2go.org/releases/binary-macosx/x2goclient/main/4.1.2.1/)

adamwolf commented 5 years ago

I'm convinced. I'll set up the 14.04 builder to build with 14.04 as the minimum and upload the DMG.

On Tue, Oct 23, 2018, 4:54 PM Seth Hillbrand notifications@github.com wrote:

We may need to bit the bullet and release two packages for Mac. That is what x2Go ended up doing ( https://code.x2go.org/releases/binary-macosx/x2goclient/main/4.1.2.1/)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/217#issuecomment-432435160, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYWpnuFPlGI88btbnRIyjBqbgCvCQks5un4_4gaJpZM4W_zPS .

adamwolf commented 5 years ago

I have set up the 14.04 builder to build and they've been uploading for a few days. I am going to close this, unless we see more issues.