search

KiCad / kicad-mac-builder

The macOS V5+ KiCad builder and packager [moved to https://gitlab.com/kicad]
13 stars 6 forks source link

libngspice bundling issue #242

Closed adamwolf closed 5 years ago

adamwolf commented 5 years ago

Some macOS versions are having issues with bundling libngspice.

Check to make sure they're the same versions, and compare 10.14, where it is working now, to 10.11 and 10.12 where it used to work but is now not working.

adamwolf commented 5 years ago

This may be some sort of race condition. It appears to randomly fail, without obvious errors, and other builds are fine. This didn't happen at all for a while, but now it happens maybe 50% of the time.

I will be continuing to monitor this.

I am turning some builds to j=1, not because I think it will fix it, but because it will help me see the differences between builds that pass and builds that fail.

I am certainly glad that I have the checker that checks every single file in the bundle!

adamwolf commented 5 years ago

This hasn't been seen since switching to one job. After we get a few nights of good nightlies, I'll do more tests.

nickoe commented 5 years ago

Any update? How can I check if there is an issue?

adamwolf commented 5 years ago

It will error out during the build since there is a tester script. I have set the builds to one core and now don't see it, but I would love to troubleshoot or have someone else troubleshoot it. It didn't show up 100%.

On Thu, Jan 3, 2019, 11:07 AM nickoe <notifications@github.com wrote:

Any update? How can I check if there is an issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/242#issuecomment-451209432, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYY9_ByG-v5na_q5Y1KArqaTUaE0rks5u_ji5gaJpZM4Y1k6N .

adamwolf commented 5 years ago

This is still happening intermittently during builds. I am investigating. We explicitly fixup the libngspice library that it complains about. The next build that fails, I need to make sure that NGSPICE_HELPER is set in the CMakeLists.txt for kicad.

adamwolf commented 5 years ago

I am continuing to dig into this today.

adamwolf commented 5 years ago

This no longer happens.