search

KiCad / kicad-mac-builder

The macOS V5+ KiCad builder and packager [moved to https://gitlab.com/kicad]
13 stars 6 forks source link

Bump ngspice to ngspice-30-2 #256

Closed nickoe closed 5 years ago

nickoe commented 5 years ago

I am not sure where there is a ngspice-30 and ngspice-30-2 tag upstream, but I guess we should choose the dash two version.

nickoe commented 5 years ago

@adamwolf Any concerns or should I merge it and we will see if it works on the nightlies?

adamwolf commented 5 years ago

You can merge it. Let's see if it builds tonight!

On Thu, Jan 3, 2019, 11:06 AM nickoe <notifications@github.com wrote:

@adamwolf https://github.com/adamwolf Any concerns or should I merge it and we will see if it works on the nightlies?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/pull/256#issuecomment-451209166, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYezM9l4Y-qDXkw4HvM4AD9GAjtNDks5u_jiDgaJpZM4Zm7Ym .

adamwolf commented 5 years ago

Thanks, by the way!

On Thu, Jan 3, 2019, 11:48 AM Adam Wolf <adamwolf@feelslikeburning.com wrote:

You can merge it. Let's see if it builds tonight!

On Thu, Jan 3, 2019, 11:06 AM nickoe <notifications@github.com wrote:

@adamwolf https://github.com/adamwolf Any concerns or should I merge it and we will see if it works on the nightlies?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/pull/256#issuecomment-451209166, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLYezM9l4Y-qDXkw4HvM4AD9GAjtNDks5u_jiDgaJpZM4Zm7Ym .

adamwolf commented 5 years ago

Gotta reject it, unfortunately.

03:08:47 default: [ 57%] Building CXX object eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o 03:08:48 default: In file included from /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.cpp:28: 03:08:48 default: /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.h:31:10: fatal error: 'ngspice/sharedspice.h' file not found 03:08:48 default: #include <ngspice/sharedspice.h> 03:08:48 default: ^ 03:08:49 default: 1 error generated. 03:08:49 default: make[6]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o] Error 1