search

KiCad / kicad-mac-builder

The macOS V5+ KiCad builder and packager [moved to https://gitlab.com/kicad]
13 stars 6 forks source link

update ngspice #257

Closed adamwolf closed 5 years ago

adamwolf commented 5 years ago

@nickoe made a PR #256 for updating to the latest ngspice tag. It didn't work, and fails with:

03:08:47 default: [ 57%] Building CXX object eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o 03:08:48 default: In file included from /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.cpp:28: 03:08:48 default: /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.h:31:10: fatal error: 'ngspice/sharedspice.h' file not found 03:08:48 default: #include <ngspice/sharedspice.h> 03:08:48 default: ^ 03:08:49 default: 1 error generated. 03:08:49 default: make[6]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o] Error 1

Let's fix this.

nickoe commented 5 years ago

Where is the full log?

adamwolf commented 5 years ago

https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-upload/76/consoleFull

adamwolf commented 5 years ago

@nickoe I tried updating ngspice again. Here's the log.

https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-upload/249/consoleFull

nickoe commented 5 years ago

This is the error:

[ 53%] Building CXX object eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o
In file included from /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.cpp:28:
/vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.h:31:10: fatal error: 'ngspice/sharedspice.h' file not found
#include <ngspice/sharedspice.h>
         ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

It does look like --with-ngshared is enabled and it does build some sharedspice.c, but maybe the header is not installed to the correct location?

But then I see: /usr/bin/install -c -m 644 noisedef.h numcards.h numconst.h numenum.h numgen.h numglobs.h onedev.h onemesh.h opdefs.h optdefs.h optndefs.h outpdefs.h plot.h pnode.h profile.h pssdefs.h pzdefs.h randnumb.h sen2defs.h sensdefs.h sensgen.h sharedspice.h sim.h smpdefs.h sperror.h spmatrix.h stringskip.h stringutil.h suffix.h swec.h tfdefs.h trandefs.h trcvdefs.h tskdefs.h twodev.h twomesh.h typedefs.h wordlist.h 1-f-code.h FastNorm3.h '/vagrant/build/ngspice-dest/include/ngspice'

Where it do look like it is installed to /vagrant/build/ngspice-dest/include/ngspice/.

But it looks like the issue may be that above install location and the location used for cmake of kicad is: -DNGSPICE_INCLUDE_DIR=/vagrant/build/ngspice-dest/share/ngspice/include/ and does not match above.

But it does look like cmake is happy with it...: -- Found ngspice: /vagrant/build/ngspice-dest/share/ngspice/include

Is ngspice ever installed to that location at any point? Or could this be some leftovers from previous versions? Is the /vagrant/build location completely virgin when we initiate a build?

adamwolf commented 5 years ago

Yeah... that didn't happen with ngspice 28. I'm going to revert it but keep it building on a branch. I am not able to put more effort into the ngspice stuff at this time but maybe someone else can do PRs then.

On Mon, Jun 24, 2019 at 3:08 AM nickoe notifications@github.com wrote:

This is the error:

[ 53%] Building CXX object eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o In file included from /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.cpp:28: /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.h:31:10: fatal error: 'ngspice/sharedspice.h' file not found

include <ngspice/sharedspice.h>

     ^~~~~~~~~~~~~~~~~~~~~~~

1 error generated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/257?email_source=notifications&email_token=AAAIWYL5WRQE5ZGOOYGHMALP4B6HTA5CNFSM4GN43X7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMD5GA#issuecomment-504905368, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIWYIHKUWP2TMJFJSTS4LP4B6HTANCNFSM4GN43X7A .

adamwolf commented 5 years ago

The job will be at https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-ngspice-upload/

adamwolf commented 5 years ago

Alright, the job built, here: https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-ngspice-upload/1/consoleFull

adamwolf commented 5 years ago

nickoe, the build is on a completely brand new VM every single time. I'll try changing the include path. Thanks for the sleuthing.

adamwolf commented 5 years ago

I got it working on my dev machine. Pushed to the branch, we 'll see what happens overnight.

nickoe commented 5 years ago

@adamwolf Could you check your build nodes? The builds have been running for 1 day and 15 hours by now. Maybe the build script is running too many things in parralel and using all the machine memory?

adamwolf commented 5 years ago

I'll take a look. Thanks Nick. I was trying to get the build machines to also have build a new template 10.15 Beta VM so it's likely I was just optimistic...

On Mon, Jul 1, 2019, 3:45 AM nickoe notifications@github.com wrote:

@adamwolf https://github.com/adamwolf Could you check your build nodes? The builds have been running for 1 day and 15 hours by now. Maybe the build script is running too many things in parralel and using all the machine memory?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/257?email_source=notifications&email_token=AAAIWYOHJ4VY3IJTN76OJ5DP5G72HA5CNFSM4GN43X7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY5N3VY#issuecomment-507174359, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIWYM4BG3GVPMR7SUM7RTP5G72HANCNFSM4GN43X7A .

nickoe commented 5 years ago

@adamwolf ok, the build did became green!!!! woo

https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-ngspice-upload/10/

I guess we can merge https://github.com/KiCad/kicad-mac-builder/pull/286

adamwolf commented 5 years ago

Thanks nick and everyone for your patience!

On Mon, Jul 1, 2019 at 3:04 PM nickoe notifications@github.com wrote:

@adamwolf https://github.com/adamwolf ok, the build did became green!!!! woo

https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-ngspice-upload/10/

I guess we can merge #286 https://github.com/KiCad/kicad-mac-builder/pull/286

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-mac-builder/issues/257?email_source=notifications&email_token=AAAIWYICN6XB2SV26FF7VPLP5JPOJA5CNFSM4GN43X7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7GISA#issuecomment-507405384, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIWYMWT5TSOEJRTFCTCJTP5JPOJANCNFSM4GN43X7A .

nickoe commented 5 years ago

@adamwolf Maybe you should delete the ngspice-upload build and re-enable https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-upload/ ?

adamwolf commented 5 years ago

Done!

On Mon, Jul 1, 2019 at 3:54 PM nickoe notifications@github.com wrote:

@adamwolf Maybe you should delete the ngspice-upload build and re-enable https://builder.wayneandlayne.com/job/kicad-mac-builder-10.14-upload/ ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.