search

KiCad / kicad-packages3D

Official KiCad 3D model libraries for rendering and MCAD integration
https://kicad.github.io/packages3d
Other
473 stars 431 forks source link

Radial capacitors have no height #247

Open strombom opened 6 years ago

strombom commented 6 years ago

Is there a reason that the radial capacitors have diameter and pitch, but no height? All seems to have the same length as diameter.

Example: CP_Radial_D10.0mm_P3.50mm

The axial capacitors have diameter, pitch and length, example: CP_Axial_L93.0mm_D29.0mm_P100.00mm_Horizontal

Is this by design or a mistake?

evanshultz commented 6 years ago

This is a good question and something that has come up in discussions at the old repos.

Quick answer: Radial caps do not require height to define the footprint, while axial caps do.

Adding the various heights for each radial cap size (diameter and lead pitch) would result in dramatically more footprints and 3D models. However, without having height specified by the selected footprint the actual capacitor height in the 3D viewer is not connected with the real part selected by the user. (Another consideration is that for a given electrical spec there may have a range of heights available.)

Personally I'd like to include height, at least just for the visual representation and manual checking. But since KiCad's design constraint system is so weak there's not much that can be done by having the actual height to automatically capture any part collisions, chassis collisions, or other mechanical checks. So it seems a bit hard to make this a high priority in my opinion.

Shackmeister commented 6 years ago

Im currently redoing the radial smd caps footprints and models.. I can add heights if @poeschlr and the other librarians would agree on it

strombom commented 6 years ago

I started going through Jamicons datasheets to make a table of all D x L x p combinations. Then maybe Nichicon and some more. Would that be of any use or is this information already available somewhere?

strombom commented 6 years ago

Here is a list of capacitor sizes. The height is max height including tolerance, that's why there are many variants, maybe they should be rounded up to closest 1mm or 0,5mm.

https://pastebin.com/SqtPhgfM

Edit: A table with nominal sizes: https://pastebin.com/5niGMihq

jkriege2 commented 6 years ago

I scripted the footprints (and the first, now obsolete round of semi-scripted 3D models), I decided against the height, as I wanted to arrive at a useful set of footprints. That was also before the proper mechanical CAD library, so 3D models were more for nice representation, not so much for exactness. As @evanshultz said above, therefore I skipped the height (actually anything that was not necessary to specify the footprint) and took a "representative" height (whatever that is) for the 3D models.

I think we have several comparable cases:

jkriege2 commented 6 years ago

We could start out by adding the height to the existing footprints/models and then go on by extending the range of available footprints. But bear in mind that this might really explode the lib of footprints!

antoniovazquezblanco commented 6 years ago

I don't want to get offtopic but it would be desirable to have a 3D model selection tool in the same way footprints are chosen.

What do you think about that feature? It would avoid footprint duplicity. It would also fix the LED color problem in models.

Shackmeister commented 6 years ago

We discussed it somewhere I cant remember and we (@evanshultz) made a bug on launchpad.

antoniovazquezblanco commented 6 years ago

Bug report by @evanshultz: https://bugs.launchpad.net/kicad/+bug/1766323

Another related bug? https://bugs.launchpad.net/kicad/+bug/1685004

Given that the feature was already requested I don't see the point on generating a ton o footprints to solve this issue to later delete them. Can we plan this in advance taking into account that the feature may be available in the future?

poeschlr commented 6 years ago

The earliest this can be added is with v6 which by my estimate is 2 years away. Maybe more depending on how long it takes to get 5.1 out. So right now we should work as if this feature will never arrive.

antoniovazquezblanco commented 5 years ago

I am working on an extremely tight design that needs case manufacturing. I need to use the appropriate 3D models for this and I could not find the desired 3D model in the repo.

I was wondering if a PR that would rename THT cap 3D models to include the actual height would be accepted. @poeschlr ?

The idea would be to allow me to later submit new models that the user may choose from in case they need it.

antoniovazquezblanco commented 5 years ago

Related issue https://github.com/KiCad/kicad-footprints/pull/1715