search

KiCad / kicad-packages3D

Official KiCad 3D model libraries for rendering and MCAD integration
https://kicad.github.io/packages3d
Other
470 stars 431 forks source link

footprint reference to or file name of DRT-3 is wrong #452

Closed tolot27 closed 5 years ago

tolot27 commented 5 years ago

kicad-footprints/Package_TO_SOT_SMD.pretty/Texas_DRT-3.kicad_mod#L30 references Texas_DRT-3.wrl but the 3D models are not prefixed with Texas_. Instead, they are named DRT-3.step and DRT-3.wrl. According to KLC F9.3 they should be prefixed with Texas_. But for other components I see sometimes the transision to vendor-free names. How to deal with this in this particular case?

evanshultz commented 5 years ago

Thanks for catching this and taking the time to create an issue!

For this footprint it's just an oversight. I renamed the footprint at https://github.com/KiCad/TO_SOT_Packages_SMD.pretty/pull/58 but the 3D model didn't get renamed.

Did you find any other problems?

@Misca1234 @easyw Would one of you guys be able to handle the renaming? Or if it's just renaming the file, I'm happy to do that. If the model needs some internal assembly renamed it might be best if one of you gurus did it.

Misca1234 commented 5 years ago

Renamed, see https://github.com/KiCad/kicad-packages3D/pull/453

tolot27 commented 5 years ago

Thanks for renaming it.

Did you find any other problems?

Not yet. I switched from Eagle to KiCad and this was my first toy project as I ran into this issue. The 3D model of this part looks a bit too high to me but I cannot measure it because there are no 3D FreeCad sources of the corresponding step file.

Nevertheless, I miss quite a lot of symbols, footprints and 3D models (Micro-MaTch, Phoenix PTSM, etc.) and I started to look how to create them programmatically.

Misca1234 commented 5 years ago

Welcome

Just bear in mind Repository https://github.com/pointhi/kicad-footprint-generator Contain a lot of scripts for generating foot prints from parameter files

Repository https://github.com/easyw/kicad-3d-models-in-freecad Contain a lot of scripts for generating 3D models from parameter files

I am doing some scripting at the moment where I check BGA, QFN, QFP and SOIC foot prints if they are missing their 3D model and if so, parameters are created and the 3D model is generated, see this push, 103 SOIC 3D models in one go https://github.com/KiCad/kicad-packages3D/pull/444

Before you spend a lot of work creating many models or foot prints and becaosue you are new to KiCad community it could be a good idea to post your ideas in the issue list before undertaking a large and perhaps unnecessary work.

evanshultz commented 5 years ago

The fix has been merged. Thanks for reporting it!

If you do find other similar issues, I'll leave this open for a few more days so you can report them. And if you find a different problem, please create a new issue for it.

We would be happy if you have the time and skill to submit PRs that grow the KiCad library! :)

Misca1234 commented 5 years ago

@tolot27 If you are happy, you can close this issue if you want

tolot27 commented 5 years ago

Up to now, I did not find any further issues.

Regarding to potential PRs in the future: I'm willing to create/add every part I use and which is missing in the existing libraries. Lack of time is always an issue. Nevertheless, I like the generators and CadQuery to automate the task as much as possible. Are there also generators for symbols available? Where to discuss the general workflow or questions not covered by KLC? Here, in a specific issue or shall I join the KiCad library mailing list?

evanshultz commented 5 years ago

Feel free to join the librarian mailing list if you're interested. If the question is a prerequiste to submitting a PR then usually an issue in the relevant repo (symbol, footprint, package-3D) is fine.

Footprint generator is at https://github.com/pointhi/kicad-footprint-generator. Symbol generators are at https://github.com/bobc/kicad-symgen and https://github.com/KiCad/kicad-library-utils/tree/master/schlib/autogen.