On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).
Thanks for creating a pull request to contribute to the KiCad libraries!
Remember you must be the legal owner of the 3D model! Models downloaded from a manufacturers website cannot be accepted.
To speed up integration of your PR, please check the following items as you complete them:
[ ] A screenshot of the model(s) aligned with KiCad footprint(s)
[ ] Source files are contributed on the apropriate location
[ ] 3D model alignment checked against KiCad footprint
[ ] WRL model uses correct material properties
[ ] Geometry check performed on the model
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above).
PS : same comment already made for the footprints:
the existing models generated with the generator are not exactly the same in the package3D library
some are present in the packages3D repo but not generated by the generator... (maybe they should just be removed, I'm not sure but it seems this is because they are duplicated with a different name)
Is it something already known ?
Add all WA-SMSI M2.5 parts from https://www.we-online.com/catalog/en/SMSI_SMT_STEEL_SPACER_M2_5_THREAD_INTERNAL/ (the other sizes already exist)
Footprint PR: https://github.com/KiCad/kicad-footprints/pull/2452 Footprint generator PR: https://github.com/pointhi/kicad-footprint-generator/pull/608 Packages 3D PR: https://github.com/KiCad/kicad-packages3D/pull/726 Packages 3D generator PR: https://github.com/easyw/kicad-3d-models-in-freecad/pull/392
Image of the part from WE:![o92910v209 Family_WA-SMSI_M2-M2 5](https://user-images.githubusercontent.com/16516760/92308123-bdb5d080-ef9b-11ea-96bc-6fe279635cec.jpg)
Screenshot of footprint:![Capture](https://user-images.githubusercontent.com/16516760/92308168-04a3c600-ef9c-11ea-83d3-b939f7bf0be5.PNG)
Screenshot of 3D package (https://github.com/pointhi/kicad-footprint-generator/pull/608):![Capture](https://user-images.githubusercontent.com/16516760/92322709-39169100-f033-11ea-9263-3fe0fb585b5c.PNG)
:warning: Deprecation warning
On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by
kicad-bot
(importer documentation).Thanks for creating a pull request to contribute to the KiCad libraries! Remember you must be the legal owner of the 3D model! Models downloaded from a manufacturers website cannot be accepted.
To speed up integration of your PR, please check the following items as you complete them:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above).