KiCad / kicad-symbols

Official KiCad schematic symbol libraries for Kicad 5
https://kicad.github.io/symbols
Other
707 stars 746 forks source link

SPI interface pins of a lot of symbols have the wrong electrical type. #232

Open poeschlr opened 6 years ago

poeschlr commented 6 years ago

The following is only valid for symbols of devices that do not use the same pins for other functions.

For master devices the electrical types should be as follows:

For slave devices:

jkriege2 commented 6 years ago

Two comments on that:

  1. When we correct, we should take care to check for the existence of a CS-pin ... if it's not there it might well be that MISO is a true output (don't know if there are really devices THAT simple ... but could be)
  2. I checked the SDA/SCL pins of I2C and made a PR to fix a few bugs: https://github.com/KiCad/kicad-symbols/pull/233
bobc commented 6 years ago

I have a PR in progress for Memory_EEPROM (#222), I will it update for MISO pin types.

I would be a bit wary of doing global edits without checking datasheets, it could lead to more errors then we solve like that (well, I already made that mistake once!).

In all the libs I have reworked so far, they all have parts with pin types that are just completely wrong (e.g. power pins set to power out instead of power in, outputs set as inputs etc). I guess it might help to do some global edits, but most of the bad parts need a complete overhaul anyway.

jkriege2 commented 6 years ago

Yes ... For the I2C it was rather quick (with a text-editor global search you quickly find the ones with another type than the expected one and can check them ine-by-one then ...), but it's going to be checking each one separately in the end ... I fear