KiCad / kicad-symbols

Official KiCad schematic symbol libraries for Kicad 5
https://kicad.github.io/symbols
Other
706 stars 745 forks source link

Add Recom RAC20-xxDK Dual Output Parts #3090

Closed Werni2A closed 4 years ago

Werni2A commented 4 years ago

Datasheet

image


:warning: Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:


Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

repo-lockdown[bot] commented 4 years ago

This repository does not accept pull requests at this time, see the README for details.

Werni2A commented 4 years ago

@myfreescalewebpage you merged the RAC-20 single output parts, this PR adds the remaining dual output parts of the series. Maybe you also want to take a look at this one. No pressure :)

myfreescalewebpage commented 4 years ago

I will take this, this is a great ddition

myfreescalewebpage commented 4 years ago

Can you solve the branch conflict now, the PR is opened

Werni2A commented 4 years ago

@myfreescalewebpage Not sure why it was closed but now the conflict should be fixed.

myfreescalewebpage commented 4 years ago

The repo is locked and all new PR are automatically closed.

myfreescalewebpage commented 4 years ago

About your symbol, only one comment:

Joel

Werni2A commented 4 years ago

Is there some guideline according to the naming of the symbol pins in AC/DCs? E.g. should all symbols in the lib have the same name for output pins or should be exactly as in the datasheet? One of the symbols should be adjusted.

Btw. I reduced the symbol size.

image

myfreescalewebpage commented 4 years ago

Is there some guideline according to the naming of the symbol pins in AC/DCs? E.g. should all symbols in the lib have the same name for output pins or should be exactly as in the datasheet?

Not related to converter only, all symbol should carefully follow the datasheet. Else this is a nice mess !!! We just ask people to copy/paste the names.

One of the symbols should be adjusted.

Which one ?

Werni2A commented 4 years ago

Then I need to fix https://github.com/KiCad/kicad-symbols/pull/2692 you merged earlier and this PR.

I will address this tomorrow afternoon.

Notes for myself:

image

myfreescalewebpage commented 4 years ago

Ohhh good point.

For the first subject, we also do not create pin name too much long so here it is accepted to keep AC(L) and AC(N). For the second subject, you're right, and I notice RAC01 series in the lib has the same problem. If you create a pull request ping me and I will review it. Else, this is not an important trouble.

Joel

Merging this PR now.