KiCad / kicad-symbols

Official KiCad schematic symbol libraries for Kicad 5
https://kicad.github.io/symbols
Other
706 stars 745 forks source link

Change 'serial' dual diodes to 'series' #3091

Closed evanshultz closed 4 years ago

evanshultz commented 4 years ago

This is a followup to https://github.com/KiCad/kicad-symbols/pull/2980, which was a followup to https://github.com/KiCad/kicad-symbols/pull/1650. I only changed a dozen dual diode symbols from having Serial in the symbol name to Series. I made sure to save before making changes and there were none, but unfortunately the Git diff makes things look more confusing than just that simple symbol name change.

@chschlue You merged https://github.com/KiCad/kicad-symbols/pull/2980 so do you mind?


:warning: Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:


Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

repo-lockdown[bot] commented 4 years ago

This repository does not accept pull requests at this time, see the README for details.

evanshultz commented 4 years ago

Good catch. I think that should be all of them.