search

KiCad / kicad-templates

KiCad project templates
Other
169 stars 135 forks source link

KiCad thinks CMakeModules is a template #14

Closed pointhi closed 5 years ago

pointhi commented 6 years ago

KiCad thinks CMakeModules is a template and tries to open icon and html from it

19:37:49: Kann Datei './kicad-templates/CMakeModules/meta/icon.png' nicht öffnen (Fehler 2: Datei oder Verzeichnis nicht gefunden)
19:37:49: Konnte das Bild aus der Datei "./Kicad/kicad-templates/CMakeModules/meta/icon.png" nicht laden.
19:37:49: Kann Datei './kicad-templates/CMakeModules/meta/info.html' nicht öffnen (Fehler 2: Datei oder Verzeichnis nicht gefunden)

Probably templates should get a .template suffix in the future to distinguish them from normal directories

nickoe commented 6 years ago

I wonder if that uninstall module thing is even needed, I would have expected make uninstall to work fine with default cmake.

nickoe commented 5 years ago

@stambaughw as you comitted the CMakeModules, do you have any thoughts on this one?

stambaughw commented 5 years ago

This is happening because the user is most likely is pointing the template path to a git repo which contains all of the CMake stuff that doesn't get installed. The CMakeModules path is not installed when make install is run. The problem with using a suffix like .template is that it will require source code changes and users will always have to use this suffix when creating template folders which is less than ideal.

On 10/16/2018 5:01 AM, nickoe wrote:

@stambaughw https://github.com/stambaughw as you comitted the CMakeModules, do you have any thoughts on this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/kicad-templates/issues/14#issuecomment-430158722, or mute the thread https://github.com/notifications/unsubscribe-auth/AFnmpm4JR2SVh0yhkx1UIwNQQ-HoUQOxks5ulaBpgaJpZM4U-DIR.

antoniovazquezblanco commented 5 years ago

I would vote to use the .template suffix following what already has been done with footprints and 3D models unless any other suggestion is made by any of you.

Whenever you give the green light I will create a PR with any solution we can come up.

Thank you

antoniovazquezblanco commented 5 years ago

@poeschlr any direction to move forward the issue?

antoniovazquezblanco commented 5 years ago

Using the .template suffix would also help separate template projects and worksheet templates that, in my opinion, should not be spread in folders around this repo.

Should I proceed and rename all the project templates with the .template suffix?

@poeschlr @stambaughw

Thanks!

stambaughw commented 5 years ago

@antoniovazquezblanco, adding a .template suffix to the template paths will not have any affect until there is code in place to do this and I'm not sure this is inherently a good idea. We force this behavior with footprint library path names and I'm not entirely happy with this solution. I would rather let the user choose their own path names an have KiCad behave appropriately. Unfortunately any solution for this will likely break the current behavior so figuring out a reasonable path forward is not as easy as one would like.

antoniovazquezblanco commented 5 years ago

https://github.com/KiCad/kicad-templates/pull/21 solves the issue.

antoniovazquezblanco commented 5 years ago

The issue has been solved by #21