search

KiCad / kicad-winbuilder

Windows builder for the KiCad project based on the MSYS2 MinGW system [moved to https://gitlab.com/kicad]
51 stars 24 forks source link

Quick fix of"HOME_DIR" variable and small improvement of Readme #50

Closed jherkenhoff closed 6 years ago

jherkenhoff commented 7 years ago

Hello,

the variable HOME_DIR should point to the current users home folder in the msys environment. When multiple user folders existed, the HOME_DIR variable incorrectly contained a list of all users, not just the one logged in. That caused the build to fail. I fixed that by explicitly setting the variable depending on the currently logged in windows user.

Furthermore I made some minor tweaks to the Readme. In the next few days I wanted to extend the Readme a little more in the hope that it will be usefull for new users.

nickoe commented 6 years ago

I don't think this pull request is relevant anymore. I tested with a space and non ascii char in the username and it seems to work, only to fail when building ngspice. The build scripts from ngspice does not like paths with spaces.