search

KiCad / kicad.github.io

KiCad Library Download Page
https://kicad.github.io
36 stars 13 forks source link

Change GitHub links to GitLab in packages3d.md #34

Closed antonok-edm closed 3 years ago

antonok-edm commented 3 years ago

I noticed the links on packages3d.md were all outdated, so I've updated them to point to the newer locations on GitLab instead.

cpresser commented 3 years ago

Hi and thanks for this patch. I am not quite sure if its needed. This whole repo might get scrapped, also, the footprints and symbol parts have the same problem. Everything has moved over to gitlab.

@sethhillbrand do you know of any migration plan for this repo?

sethhillbrand commented 3 years ago

We are going to set up the equivalent kicad.gitlab.io site but we haven't yet. I don't see the harm in this patch and it will certainly help folks in the interim.

I'd say we can merge.

coliss86 commented 3 years ago

@cpresser any update on this please ?

sethhillbrand commented 3 years ago

No harm in merging. @antonok-edm Would you be able to update the remaining links (Footprints, Symbols) in the same PR?

antonok-edm commented 3 years ago

@sethhillbrand I updated those and index.md, as well as other references to GitHub and GitHub-specific terminology (i.e. pull request -> merge request).

There's still a GitHub link/logo at the bottom of every page, which I could handle as well if you'd like. Seems like either the Icon or Icon - 1-color (black) options available at https://about.gitlab.com/press/press-kit/ would be suitable here - any preferences?

sethhillbrand commented 3 years ago

@antonok-edm I'm fine with leaving the logo. This is hosted on GitHub after all :)