search

KiKaraage / ArcWTF

A userChrome.css theme to bring Arc Browser look on Windows to Firefox. Work with Windows, Linux and macOS ✨
1.34k stars 29 forks source link

--toolbar-bgcolor makes the url suggestion bar have transparent background #16

Closed susanthenerd closed 8 months ago

susanthenerd commented 9 months ago

Hello!

I'm running the main branch and while playing around with it I found that URL suggestion pop-out has a transparent background.

This is most probably due to the use of --toolbar-bgcolor when setting the background, variable which on default configuration of Adaptive Tab Bar Color is set to be transparent. I believe ATBC has a separate CSS variable that can be used only for the URL bar, but I'm not sure.

This issue was introduced in commit 54413902c58b9792a7ee1150ce82b3e82453db24

KiKaraage commented 9 months ago

Okay can you help test it by replacing --toolbar-bgcolor with --tabpanel-background-color? I'm currently not using Adaptive Tab Bar Color now

KiKaraage commented 9 months ago

....also I think "same color" would be more accurate than "transparent". You can change findbar color from "toolbar" section on the ATBC's addon settings. gambar

susanthenerd commented 9 months ago

Okay can you help test it by replacing --toolbar-bgcolor with --tabpanel-background-color? I'm currently not using Adaptive Tab Bar Color now

I did that and it works correctly now.

On a note, I think having the pop out the same color with the application menu(or whatever is called) would be much better, but I'm not sure what variable is used for that.

KiKaraage commented 9 months ago

same color with the application menu

I searched on edge-frfox color.css and seems like both menu and panels (so, context menu should be included here?) uses --arrowpanel-background-color. Some other things like popup dialogs uses that parameter too

jacksonsamuelmoore commented 9 months ago

Ran into this problem and did some testing: it appears the test commit (08423c9) actually sort of breaks things. I found that it results in a semi-transparent pop-out with or without ATBC. Reverting it fixes the bar when not using ATBC. When using ATBC, the pop-out is fully transparent by default, but increasing the background value in the toolbar settings of ATBC by one stop seems to fix it completely: image

Some screenshots:

With --arrowpanel-background-color without ATBC: image

With --arrowpanel-background-color with ATBC and toolbar fix applied: image

With --toolbar-bgcolor without ATBC: image

With --arrowpanel-background-color with ATBC and toolbar settings fix not applied: image

With --arrowpanel-background-color with ATBC and toolbar settings fix applied: image

I'm testing with the Firefox Flatpak on Fedora 39, but I think it should be the same on Windows.

Hope this is helpful!

susanthenerd commented 9 months ago

Hello! I can confirm increasing the toolbar background variable in the settings now fixes the issue. Thank you.

PixsaOJ commented 8 months ago

--arrowpanel-background-color is supposed to be --arrowpanel-background Thats the problem !

There has not been such thing as --arrowpanel-background-color for what I have checked in https://github.com/bmFtZQ/edge-frfox/blame/main/chrome/global/colors.css