KiKaraage / ArcWTF

A userChrome.css theme to bring Arc Browser look on Windows to Firefox. Work with Windows, Linux and macOS ✨
1.32k stars 28 forks source link

Librewolf Support #5

Open Enigma1309 opened 9 months ago

Enigma1309 commented 9 months ago

Librewolf is same as firefox but with privacy features enabled, i installed this theme and everything seems to work out of the box.....sideberry, icons and everything else just worked fine... except when i turned off Adaptive tab bar color in the extensions menu my config break kinda. in firefox if i turned off the adaptive tab bar color it just works see image everything seems to be perfect

but when i do the same in librewolf image the consisency seems to break, if i re-enable it just works, but i don't wanna use adaptive tabbar color always

your theme works when i install the setup, but it breaks after enabling and disabling the adaptive tabbar color.

Also is there any way to turn this off, this only gets enabled if i use adaptive tabbar color (i'm on linux Hyprland i don't want close button like windows) image

Sorry for my bad english Thanks in advance ❤️

KiKaraage commented 9 months ago
  1. For navbar color issues: Have you tried other themes (outside of Firefox default dark/light/system themes)? You can also turn custom settings CSS off ( in about:config), restart, turn it on again, and restart Librewolf again.
  2. For the window controls: Try this CSS. Put it on chrome/tweaks, and add this command on your userchrome.css:
@import url("tweaks/window_control_force_linux_system_style.css");
Enigma1309 commented 9 months ago

okay i've made a new profile in librewolf and just installed the Adaptive Tab-bar color extension , whenever i turned it on it automatically spawned an windows like control( close, maximize, minimize ) so i think i have to make a issue there.

But when i turned on and off the extension it resumes it's older state (i.e same color as default) am i missing out on something?

i tried to recreate your config in the newprofile and i got to the same result ( broken color) and it kinda disappoints me

i don't have much knowledge about how to fix this :\ anyone please help me out.

KiKaraage commented 9 months ago

Please tell me if you have done the 2nd step. Screenshot(s) would be appreciated!

Hmmm I have to try Librewolf.....

Also, how about doing this on Firefox? Would you got similar bugs after installing my theme and Adaptive Tab Bar Color?

Enigma1309 commented 9 months ago

Yes it works on firefox

in firefox if i turned off the adaptive tab bar color and it just works see image everything seems to be perfect

yes i did the second step and that isn't the problem anymore, i think the issue of windows button is due to the extension itself

Here are the steps if i ain't doing anything wrong

1) Creaating profile image

2) Launching bare profile image

3) Enabling userchrome.css customization (it's same as about:config) image

4) Installing Necessary Extensions image

5) Configuring userchrometoggle image

6) Importing Sideberry CSS image

7) Still looks the same image

Enigma1309 commented 9 months ago

Here is a short video demonstrating the effect

https://github.com/KiKaraage/ArcWTF/assets/94917588/ef80985c-038e-4963-a2ca-fec56374a5f4

LuanderFarias commented 9 months ago

i have the same problem when using more than one window. as far as i've researched it's because of the sidebery extension, since it actively searches for the color of the browser window but it takes some seconds and get desincronized from the frame. i'm still looking for a fix.

Enigma1309 commented 9 months ago

Hey i think i found the cause of the problem, it'a happening when the LibreWolf color-scheme is set to default

image

when setting it to the dark or light it automatically works, but sideberry css seems to have some issues with the system auto theme in LibreWolf

image image

IDK why is this happening but i've narrowed down my approach to this problem as sideberry not able to diffrentiate auto theme

LuanderFarias commented 9 months ago

found a temporary solution: https://github.com/linonetwo/browser-adaptation-dynamic-theme

KiKaraage commented 9 months ago

Yeah that's why I suggest not to use Firefox default system theme.

Also, after nonactivating Adaptive Tab Bar Color Firefox default theme will automatically applied, so just apply other theme and the issue with Sidebery is solved

About the window-controls.... Sadly I don't see settings related to window control buttons on the addon option, so you might want to use other addons as advised above. You can also submit an issue on their Github.... The author are currently busy tho.

Oh yeah, hi and thank you @LuanderFarias for replying! May I know the setup you're using right now? (OS & Firefox version)

LuanderFarias commented 9 months ago

thanks for the ping. i'm using a windows firefox version 122.0.

still working on a possible solution for the problem with the color and etc... but it's hard since i'm focusing more on arcfox lol. So far i've discovered that the extension pushes the color from the main page header but pass some filters before applying and using it. also, i've been thinking about using other things than the extension, maybe a user.js or something like... but nothing much on the moment...

Enigma1309 commented 9 months ago

i am still unable to find the fix, this doesn't solve it either

LuanderFarias commented 9 months ago

yeah me too. don't know why this got the complete status without any warning :(

Enigma1309 commented 8 months ago

one solution to this issue may be create a firefox color config and use it, since sideberry reacts well on firefox color extension

Enigma1309 commented 8 months ago

image

i did these changes and the buttons got disappeared, but how do i trim the excess space, ther isn't any flexible space either but i can't get it to be removed 😬

KiKaraage commented 8 months ago

You can customize it from hide-tabs-bar.css line 125 for Linux

gambar

But to be precise, you can inspect it by yourself with Browser Toolbox (ctrl + shift + alt + i). Let me know your result and if there's something I can apply to the codes.

Enigma1309 commented 8 months ago

+ var(--uc-titlebar-drag-space))

removing this fixes this issue for me 🫶

also i wanna remind that in the latest version the tabs aren't showing in the private window , downgrading fixes it temporarily

KiKaraage commented 8 months ago

+ var(--uc-titlebar-drag-space)) removing this fixes this issue for me 🫶

I wonder if this is applicable to all Linux case, since default value is 40px.

also i wanna remind that in the latest version the tabs aren't showing in the private window , downgrading fixes it temporarily

Can you show it with screenshots? I haven't been able to grasp this problem, and private window works good enough for me (of course with Sidebery and Userchrome Toggle disabled on private, so the horizontal tabs won't be hidden).

Enigma1309 commented 8 months ago

i was recording the steps to reproduce and now , It seems to work idk what was causing this 😐

as soon as i switched to new config the hide-tab-tab.css didn't worked as intended so on editing line 125 as this worked:- padding-inline-end: calc(var(--uc-window-controls-width, 0px) - 90px ) !important;

i did -90 so that it matched the visuals image

KiKaraage commented 8 months ago

Alright, I'm looking for comments from more Linux users before adding it to the main repo 👍