KiameV / moogle-mod-manager

Manages mods for Final Fantasy Pixel Remastered
MIT License
25 stars 3 forks source link

Memoria Compatibility #19

Closed Albeoris closed 1 year ago

Albeoris commented 2 years ago

Hi!

How can we make your manager compatible with Memoria?

Memoria has a built-in mod loading mechanism that allows you to change individual entries in .csv and .txt files.

KiameV commented 2 years ago

If it's more to the end of editing specific csv/txt files, we could consider find/replace via regex, line number/key, or some other means. xml/json mod file would specify: file to edit, what to find/how to find, replace

On Mon, Jul 18, 2022 at 7:52 AM Travis Offtermatt @.***> wrote:

I'll need to look into memoria, Magicite, and bepinex more. Right now I am focused on moving files from a to b.

For memoria would this be enough? Move csv from mod folder to memoria folder? Before I ask too many questions beyond that let me learn how memoria works ;)

On Mon, Jul 18, 2022, 3:46 AM Albeoris @.***> wrote:

Hi!

How can we make your manager compatible with Memoria https://github.com/Albeoris/Memoria.FFPR?

Memoria has a built-in mod loading mechanism that allows you to change individual entries in .csv and .txt files.

— Reply to this email directly, view it on GitHub https://github.com/KiameV/ffprModManager/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGILGUQ3O2PE2V5OQRL66YLVUURZFANCNFSM533T7PGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Albeoris commented 2 years ago

Okay, so I don't need to tweak anything on my end?

As far as I can see, now the frameworks - BeepInEx, Memoria and Magicite are chosen by the author of the mod as the installation method.

Seems like BeepInEx, Memoria and Magicite should also be mods, and installed as dependencies when needed.

And here, it seems, some work is needed, since only a specific version can be selected in the list of required mods. And in the case of BeepInEx, Memoria, etc. it is important for us that the version is NOT lower than a certain one. Otherwise, we won't be able to install old mods that don't update dependencies.

What are you thinking about?

tofluid commented 2 years ago

In the mod xml file, there is a Mod Compatibility section. In that, there is a Required and Forbids section. For each, when a mod is Required or Forbidden, the mod's Name, Link, and Version/s are specified.

Hopefully that will cover this.

And yes, I'm thinking bepinex, memoria, etc are just mods that the user will select and install via the mod manager

Albeoris commented 2 years ago

In the mod xml file, there is a Mod Compatibility section. In that, there is a Required and Forbids section. For each, when a mod is Required or Forbidden, the mod's Name, Link, and Version/s are specified.

Yes, but now it's a strict version of the mod. In the real world we have a range: Memoria >= 2022.07.20 or Magicite >= 1.0 && < 2.0

KiameV commented 2 years ago

Yeah this will need to be thought out more. There is nothing backing versions atm. When it does become enforced tokens like ">=" or "" (ie 1.) can be considered

On Wed, Jul 20, 2022, 4:29 AM Albeoris @.***> wrote:

In the mod xml file, there is a Mod Compatibility section. In that, there is a Required and Forbids section. For each, when a mod is Required or Forbidden, the mod's Name, Link, and Version/s are specified.

Yes, but now it's a strict version of the mod. In the real world we have a range: Memoria >= 2022.07.20 or Magicite >= 1.0 && < 2.0

— Reply to this email directly, view it on GitHub https://github.com/KiameV/moogle-mod-manager/issues/19#issuecomment-1190105586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGILGUTGJLSZVQOW3VU6J7TVU7IIXANCNFSM533T7PGA . You are receiving this because you commented.Message ID: @.***>

Albeoris commented 2 years ago

I think any solutions that allow you to specify such a constraint are suitable:

Min supported version: 0.9a
Max supported version: 2022.01.01-rc3

These can be comparison operators and *, if semicolon enumeration is supported, or regular expressions.

I think we need two options: simple, where you specify: 1.1.*; 2.*; 3.*

And complex, where you can describe any regular expression for corner cases.

KiameV commented 2 years ago

I'll need to look into memoria, Magicite, and bepinex more. Right now I am focused on moving files from a to b.

For memoria would this be enough? Move csv from mod folder to memoria folder? Before I ask too many questions beyond that let me learn how memoria works ;)

On Mon, Jul 18, 2022, 3:46 AM Albeoris @.***> wrote:

Hi!

How can we make your manager compatible with Memoria https://github.com/Albeoris/Memoria.FFPR?

Memoria has a built-in mod loading mechanism that allows you to change individual entries in .csv and .txt files.

— Reply to this email directly, view it on GitHub https://github.com/KiameV/ffprModManager/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGILGUQ3O2PE2V5OQRL66YLVUURZFANCNFSM533T7PGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>