nus-pe-bot
commented
2 months ago Team's Response
Thank you for pointing this out.
However, we decided to reject this bug as it is an intended effect of the limit command.
The limit feature is designed to allow library managers to decide for themselves what's best for their libraries. Allow me to share 2 situations:
-
If the library is in an excess surplus in books, the library manager can decide to allow a negative threshold score to allow library users to borrow the books before having to donate or return books.
-
If the library is short on books, the library manager can set the threshold score to a positive score to ensure library users donate books to the community library before allowing them to borrow other books, to ensure that the library does not run out of books.
In both cases, the merit score can be either negative or positive, thus there is nothing wrong in allowing threshold be a positive number.
Restricting the use of the threshold feature as you suggested might end up hurting library manager's flexibility to set their own thresholds which will impact their ability to run the library the way they wish to.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
As a library, anybody should be allowed to borrow books unless the person has borrowed too many books. However, if i set the threshold limit to a postive number like 5 using the command 'limit 5' and users that has no donated books will not be able to borrow books since users are set to a initial merit score of 0. This could be a possible flaw since library do not require users to donate books before borrowing