search

Kiatra / BlizzMove

World of Warcraft add-on to make the default windows movable via drag & drop.
23 stars 9 forks source link

[Bug Report] UI taint related to scrolling in journal (AddOn 'BlizzMove' tried to call the protected function 'OnOpen()') #110

Closed drnoonien closed 4 months ago

drnoonien commented 1 year ago

What game version did the bug occur in?

Retail

Troubleshooting

Describe the bug.

I get a UI taint error after scrolling in the encounter journal.

Active addons at time of testing:

2x [ADDON_ACTION_FORBIDDEN] AddOn 'BlizzMove' tried to call the protected function 'OnOpen()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `OnOpen'
[string "@Blizzard_EncounterJournal/Blizzard_EncounterJournal.lua"]:587: in function <...zzard_EncounterJournal/Blizzard_EncounterJournal.lua:576>
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@FrameXML/UIParent.lua"]:2943: in function `SetUIPanel'
[string "@FrameXML/UIParent.lua"]:2786: in function `ShowUIPanel'
[string "@FrameXML/UIParent.lua"]:2651: in function <FrameXML/UIParent.lua:2647>
[string "=[C]"]: in function `SetAttribute'
[string "@FrameXML/UIParent.lua"]:3253: in function <FrameXML/UIParent.lua:3232>
[string "=[C]"]: ?
[string "=[C]"]: in function `ShowUIPanel'
[string "@FrameXML/UIParent.lua"]:3214: in function `ToggleFrame'
[string "@FrameXML/UIParent.lua"]:1150: in function `ToggleEncounterJournal'
[string "TOGGLEENCOUNTERJOURNAL"]:1: in function <[string "TOGGLEENCOUNTERJOURNAL"]:1>

Locals:
_ = Frame {
 RegisterEvent = <function> defined @!BugGrabber/BugGrabber.lua:486
 0 = <userdata>
 UnregisterEvent = <function> defined @!BugGrabber/BugGrabber.lua:486
 SetScript = <function> defined @!BugGrabber/BugGrabber.lua:486
}
event = "ADDON_ACTION_FORBIDDEN"
events = <table> {
 ADDON_ACTION_BLOCKED = <function> defined @!BugGrabber/BugGrabber.lua:552
 ADDON_ACTION_FORBIDDEN = <function> defined @!BugGrabber/BugGrabber.lua:552
 PLAYER_LOGIN = <function> defined @!BugGrabber/BugGrabber.lua:546
 LUA_WARNING = <function> defined @!BugGrabber/BugGrabber.lua:561
 ADDON_LOADED = <function> defined @!BugGrabber/BugGrabber.lua:506
}

Steps to reproduce.

1) /uireload 2) Open the encounter journal 3) Select Aberrus 4) Select the Amalgamation boss 5) Select the abilities tab 6) Scroll down to bottom (triggering move) 7) Close and re-open the journal

Expected behavior.

Expected: journal opens and closes with no errors.

Actual: subsequent opens results in a UI taint error.

drnoonien commented 1 year ago

I also have another addon that triggers this issue (TinyInspect), where this seems to be the offending code, in case that helps troubleshooting:

local GetLootInfoByIndex = EJ_GetLootInfoByIndex
if (C_EncounterJournal and C_EncounterJournal.GetLootInfoByIndex) then
    GetLootInfoByIndex = C_EncounterJournal.GetLootInfoByIndex
end
Numynum commented 1 year ago

does this happen every time for you? I've tried maybe 10 times now, and it only broke once for me.. very odd I'm not quite sure how this could be happening, to be honest

drnoonien commented 1 year ago

I can consistently reproduce it, but only doing those specific steps above, here's how it looks in video form (repro starts after loading screen) https://streamable.com/gke8s8

Numynum commented 1 year ago

Interesting.. I'm doing the exact same thing, but for me it only broke once, very odd..

drnoonien commented 1 year ago

Nuking my entire WTF folder seems to resolve it. I'll try to dig down and see if I can find out what exactly fixes it...

Ok no, it was because I tried it on a different character. Clearing WTF did nothing, and I also have differences between characters. The plot thickens...

Edit: Hm, ok so on this character (bdk), I need to do the following to trigger the error: https://streamable.com/yg7oph

drnoonien commented 1 year ago

So it seems the way it breaks in my first example is the odd scenario, I can only reproduce that on a single char. The second scenario (scroll, then return to overview and toggle window) triggers both on multiple characters and across multiple computers.

Both are related to scrolling in that ability tab.

Numynum commented 1 year ago

Are you still able to consistently reproduce it?

If so, could you help us out by providing a taintlog file?

  1. load your character, with only blizzmove, buggrabber and bugsack enabled
  2. type /console taintLog 2 in chat
  3. reload your UI
  4. reproduce the issue, in as few steps as possible
  5. type /console taintLog 0 in chat immediately after the taint error message pops up
  6. reload your UI
  7. upload World of Warcraft\_retail_\Logs\taint.log here (or on pastebin or similar)
drnoonien commented 1 year ago

Yep, still reproduces nicely. Here's the contents of taint.log

5/16 17:42:30.204  Global variable MAX_BUGGRABBER_ERRORS tainted by !BugGrabber - Interface/AddOns/!BugGrabber/BugGrabber.lua:33
5/16 17:42:30.204  Global variable BUGGRABBER_ERRORS_PER_SEC_BEFORE_THROTTLE tainted by !BugGrabber - Interface/AddOns/!BugGrabber/BugGrabber.lua:36
5/16 17:42:30.204  Global variable seterrorhandler tainted by !BugGrabber - Interface/AddOns/!BugGrabber/BugGrabber.lua:570
5/16 17:42:30.204  Global variable SLASH_BugGrabber1 tainted by !BugGrabber - Interface/AddOns/!BugGrabber/BugGrabber.lua:574
5/16 17:42:30.204  Global variable BugGrabber tainted by !BugGrabber - Interface/AddOns/!BugGrabber/BugGrabber.lua:575
5/16 17:42:30.204  Global variable LibStub tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/LibStub/LibStub.lua:8
5/16 17:42:30.210  Global variable AceGUIEditBoxInsertLink tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceGUI-3.0/widgets/AceGUIWidget-EditBox.lua:25
5/16 17:42:30.210  Global variable AceGUIMultiLineEditBoxInsertLink tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceGUI-3.0/widgets/AceGUIWidget-MultiLineEditBox.lua:22
5/16 17:42:30.210  Global variable UIDD_REFRESH_OVERREAD_PATCH_VERSION tainted by BlizzMove - Interface/AddOns/BlizzMove/TaintLess.xml:<Scripts>:38
5/16 17:42:30.210  Global variable UIDROPDOWNMENU_OPEN_PATCH_VERSION tainted by BlizzMove - Interface/AddOns/BlizzMove/TaintLess.xml:<Scripts>:52
5/16 17:42:30.210  Global variable IOFRAME_SELECTION_PATCH_VERSION tainted by BlizzMove - Interface/AddOns/BlizzMove/TaintLess.xml:<Scripts>:64
5/16 17:42:30.210  Global variable EDITMAN_OPENDROP_PATCH_VERSION tainted by BlizzMove - Interface/AddOns/BlizzMove/TaintLess.xml:<Scripts>:76
5/16 17:42:30.210  Global variable OBJTRACK_DELAYUPDATE_PATCH_VERSION tainted by BlizzMove - Interface/AddOns/BlizzMove/TaintLess.xml:<Scripts>:98
5/16 17:42:30.210  Global variable BlizzMoveAPI tainted by BlizzMove - Interface/AddOns/BlizzMove/BlizzMoveAPI.lua:12
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BLIZZMOVE1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1126
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BM1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1127
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDUMPCHANGEDCVARS1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDUMPTOPLEVELFRAMES1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDUMPMISSINGFRAMES1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDEBUGANCHOR1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDEBUGLOADALL1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable SLASH_ACECONSOLE_BMDUMPDEBUGINFO1 tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceConsole-3.0/AceConsole-3.0.lua:95 RegisterChatCommand()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/BlizzMove.lua:1129
5/16 17:42:30.210      xpcall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:494 InitializeAddon()
5/16 17:42:30.210      Interface/AddOns/BlizzMove/Libs/AceAddon-3.0/AceAddon-3.0.lua:619
5/16 17:42:30.210  Global variable ChatThrottleLib tainted by BugSack - Interface/AddOns/BugSack/Libs/AceComm-3.0/ChatThrottleLib.lua:48
5/16 17:42:30.210  Global variable BugSack tainted by BugSack - Interface/AddOns/BugSack/core.lua:31
5/16 17:42:30.210  Global variable SLASH_BugSack1 tainted by BugSack - Interface/AddOns/BugSack/core.lua:149
5/16 17:42:32.438  Global variable AdventureJournal_Reward_OnEnter tainted by BlizzMove - Interface/AddOns/BlizzMove/Libs/AceHook-3.0/AceHook-3.0.lua:241 hook()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/Libs/AceHook-3.0/AceHook-3.0.lua:321 RawHook()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/BlizzMove.lua:1228 ?()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109
5/16 17:42:32.438      securecallfunction()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:19 Dispatch()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:54 Fire()
5/16 17:42:32.438      Interface/AddOns/BlizzMove/Libs/AceEvent-3.0/AceEvent-3.0.lua:120
5/16 17:42:32.438      LoadAddOn()
5/16 17:42:32.438      Interface/FrameXML/UIParent.lua:545 UIParentLoadAddOn()
5/16 17:42:32.438      Interface/FrameXML/UIParent.lua:715 EncounterJournal_LoadUI()
5/16 17:42:32.438      Interface/FrameXML/UIParent.lua:1147 ToggleEncounterJournal()
5/16 17:42:32.438      TOGGLEENCOUNTERJOURNAL:1
5/16 17:42:38.020  SetPoint()
5/16 17:42:38.020  An action was blocked because of taint from BlizzMove - OnOpen()
5/16 17:42:38.020      Interface/AddOns/Blizzard_EncounterJournal/Blizzard_EncounterJournal.lua:587
5/16 17:42:38.020      EncounterJournal:Show()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:2943 Frame:SetUIPanel()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:2786 Frame:ShowUIPanel()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:2651
5/16 17:42:38.020      Frame:SetAttribute()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:3253 ShowUIPanel()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:3214 ToggleFrame()
5/16 17:42:38.020      Interface/FrameXML/UIParent.lua:1150 ToggleEncounterJournal()
5/16 17:42:38.020      TOGGLEENCOUNTERJOURNAL:1
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDUMPTOPLEVELFRAMES1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDUMPMISSINGFRAMES1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BLIZZMOVE1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDEBUGLOADALL1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDEBUGANCHOR1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by !BugGrabber while reading SLASH_BugGrabber1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDUMPDEBUGINFO1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BM1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BlizzMove while reading SLASH_ACECONSOLE_BMDUMPCHANGEDCVARS1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
5/16 17:42:41.802  Execution tainted by BugSack while reading SLASH_BugSack1 - Interface/FrameXML/ChatFrame.lua:2729 ChatFrame_ImportListToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:2777 ChatFrame_ImportAllListsToHash()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:5222 ChatEdit_ParseText()
5/16 17:42:41.802      Interface/FrameXML/ChatFrame.lua:4968 ChatEdit_OnSpacePressed()
5/16 17:42:41.802      ChatFrame1EditBox:hatFrame.xml:147_OnSpacePressed()
Numynum commented 1 year ago

hm, unfortunately there's nothing interesting in there 😕

if you could, would you please do the same, but on the 10.1.5 PTR? and instead of taintLog 2, use taintLog 11? that should give a ton more information, and hopefully that could pinpoint the exact cause 🙂

drnoonien commented 1 year ago

No realms currently up on the 10.1.5 PTR, will dump it when they're back. Want a taintLog 11 of retail as well?

Numynum commented 1 year ago

unfortunately, taintLog 11 only works on test builds (10.1.0 PTR isn't using a test build either) so it'll have to wait until ptr comes back up

drnoonien commented 1 year ago

Taintlog 11 from 10.1.5 - https://github.com/Kiatra/BlizzMove/files/11495194/taint.log (12mb)

Numynum commented 1 year ago

thanks, that helped pinpoint the problem though unfortunately, I don't think it's fixable without breaking a lot of functionality

there's a chance that blizzard will fix this from their end though, as a few other addons are having similar problems but in the mean time, since this error doesn't actually seem to break anything, we'll probably have to live with it for now

(for reference, the problem seems to be due to how the scrollbox gets tainted when we propagate mousewheel 'events' to the scroll box; on re-opening the frame, blizzard updates the loot, which reads the scrollbox, spreading the taint, and then calls the OnOpen protected function. A simple fix for them, would be to move the OnOpen function a few lines higher, to above the loot updating function)

Numynum commented 4 months ago

blizzard has fixed this