Kiatra / BlizzMove

World of Warcraft add-on to make the default windows movable via drag & drop.
23 stars 9 forks source link

[Bug Report] Hero Talent tree broken #132

Closed Geriamund closed 3 weeks ago

Geriamund commented 3 weeks ago

What game version did the bug occur in?

Retail

Troubleshooting

Describe the bug.

Same as #130 and #131 When swapping hero talent or closing it breaks it. Using BlizzMove v3.5.36. image image

Steps to reproduce.

1.reload using only BlizzMove, Buggrabber, and Bugsack. 2.Open the talent selection frame. 3.Click the hero talents circle at the center of the frame to open the hero talent selection screen. 4.click active button or close this window 5.The bug occurs.

Expected behavior.

Sswapping or closing without the tree disappearing

Errors

2x ...ClassTalents/Blizzard_HeroTalentsSelectionDialog.lua:431: Action[SetPoint] failed because[SetPoint would result in anchor family connection]: attempted from: Button:SetPoint.
[string "=[C]"]: in function `SetPoint'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_HeroTalentsSelectionDialog.lua"]:431: in function `PlaceHeroTalentButton'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_HeroTalentsSelectionDialog.lua"]:141: in function `PlaceHeroTalentButton'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_HeroTalentsContainer.lua"]:480: in function `UpdateHeroTalentButtonPosition'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:657: in function `UpdateTalentButtonPosition'
[string "@Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua"]:822: in function `InstantiateTalentButton'
[string "@Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua"]:1267: in function `LoadTalentTreeInternal'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:800: in function `LoadTalentTreeInternal'
[string "@Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua"]:1254: in function `LoadTalentTree'
[string "@Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua"]:1142: in function `SetTalentTreeID'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:868: in function `SetTalentTreeID'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:864: in function `SetConfigID'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:356: in function `OnTraitConfigUpdated'
[string "@Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua"]:338: in function `OnEvent'
[string "@Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua"]:338: in function <...erSpells/ClassTalents/Blizzard_ClassTalentsFrame.lua:267>

Locals:
(*temporary) = Button {
 BorderSheen = Texture {
 }
 Shadow = Texture {
 }
 spendTextShadows = <table> {
 }
 StateBorder = Texture {
 }
 SpendTextShadow2 = FontString {
 }
 Glow = Texture {
 }
 ArtSet = <table> {
 }
 SpendTextShadow4 = FontString {
 }
 deselectSound = 207762
 sheenMaskAtlas = "talents-node-choice-sheenmask"
 selectSound = 207763
 frameLevelOffset = 2
 SpendTextShadow1 = FontString {
 }
 Icon2 = Texture {
 }
 IconSplitMask = MaskTexture {
 }
 SpendText = FontString {
 }
 isGhosted = false
 definitionInfo = <table> {
 }
 visualState = 6
 IconMask = MaskTexture {
 }
 Icon = Texture {
 }
 SpendTextShadow3 = FontString {
 }
 selectedDefinitionInfo = <table> {
 }
 selectedEntryID = 117419
 talentSelections = <table> {
 }
 actionBarStatus = 1
 BorderSheenMask = MaskTexture {
 }
 entryInfo = <table> {
 }
 nodeInfo = <table> {
 }
 artSet = <table> {
 }
 talentFrame = Frame {
 }
 tooltipBackdropStyle = <table> {
 }
 StateBorderHover = Texture {
 }
 nodeID = 94822
 DisabledOverlayMask = MaskTexture {
 }
 SelectableIcon = Texture {
 }
 Ghost = Texture {
 }
 DisabledOverlay = Texture {
 }
 entryID = 117419
 SelectableGlow = Texture {
 }
 definitionID = 122431
 Icon2Mask = MaskTexture {
 }
 SearchIcon = Frame {
 }
}
(*temporary) = "TOP"
(*temporary) = Frame {
}
Numynum commented 3 weeks ago

you've set the remember positions setting to "Remember permanently" I guess? that's the only way I've been able to reproduce it again now (after quite a while of it just working fine no matter what I tried :/) looking into fix attempt nr 4 🙃

Numynum commented 3 weeks ago

with the latest update, I'm no longer able to reproduce the issue, lemme know if it works for you too 🫡

Geriamund commented 3 weeks ago

yeah i forgot to say about the "Remember permanently" my bad. Everything working as normal so far, closing the window or swapping talents on new and leveled chars are not giving errors anymore.

Numynum commented 3 weeks ago

no worries