Kiatra / ChocolateBar

ChocolateBar is a World of Warcraft addons to display plugins in a bar on top or bottom of your screen
https://www.wowace.com/projects/chocolatebar
18 stars 9 forks source link

[Bug Report] pkgmeta has obsolete URLs that point to nowhere #36

Closed Myrroddin closed 3 months ago

Myrroddin commented 6 months ago

What game version did the bug occur in?

Vanilla Classic, Burning Crusade Classic, Wrath of the Lich King Classic, Retail

Troubleshooting

Describe the bug.

Your .pkgmeta is pointing to Wowace URLs which haven't existed in years. None of your libs are being pulled from the correct repos.

Steps to reproduce.

Update your pkgmeta. Here is an example of the current URLs: RepByZone's pkgmeta.

To reference LibDataBroker-1.1, the correct format is to not use tools-used which is obsolete. Instead, use curse-slug. You can safely remove the entire tools-used section of your pkgmeta.

  libs/LibDataBroker-1.1:
    url: https://github.com/tekkub/libdatabroker-1-1/
    curse-slug: libdatabroker-1-1

Because tools-used is obsolete, you can remove findglobals as well.

Expected behavior.

Rather than bundling library versions from before Twitch, and later Amazon, bought Curseforge, bundle the current library versions from the correct repository URLs.

Errors

Given that Blizzard is being more aggressive with embedded libs not being bundled correctly, your current system will fail inevitably, and it is better to fix your issues now.
Myrroddin commented 3 months ago

The BigWigs Packager has some improvements to look at child folders. Please use the following for LibDataBroker-1.1.

libs/LibDataBroker-1.1:
  url: https://github.com/tekub/libdatabroker-1-1/LibDataBroker-1.0
  curse-slug: libdatabroker-1-1
Kiatra commented 3 months ago

Please create a pull request for the enhancements