Kibibit / hass-kibibit-theme

A milky glass theme for Home Assistant
MIT License
205 stars 21 forks source link

Icon states (on/off) are not distinguishable #56

Open Stooovie opened 3 years ago

Stooovie commented 3 years ago

HA Core 2021.2.3, kibibit theme 1.1.1. - the on/off state can't be inferred from the icon. They are all the same color (except RGB lights).

Please fix this, it's a really gorgeous theme!

A846D417-D01C-418D-9219-7FDFB4E762A1

johnjoemorgan commented 3 years ago

Experiencing the same - it's a great theme and I'd like to keep it

Yonny24 commented 3 years ago

Just installed this as it's a really nice theme but yes the 'state_color: true' is not working. Hope you find a fix

kokesh commented 3 years ago

Still doesn't work in November. Anyone actually reading issue list?

Hassiopeia commented 3 years ago

I just found this theme and love it..... except for this issue. Please fix.

Hassiopeia commented 3 years ago

@kokesh @Stooovie @johnjoemorgan @Yonny24

I found a solution that will work until it's updated:

the 'paper-item-icon-active-color:' variable needs to be added in the theme's yaml. I added it and assigned the color of my choice, I also changed 'state-icon-active-color' to the same choice, restarted HA and all is well. I'm not sure which one of those variables actually changed it since I did both, but it's working well for me now.

waring86 commented 2 years ago

Hello

maybe there is any knowledge on how to fix this error?

waring86 commented 2 years ago

@kokesh @Stooovie @johnjoemorgan @Yonny24

I found a solution that will work until it's updated:

the 'paper-item-icon-active-color:' variable needs to be added in the theme's yaml. I added it and assigned the color of my choice, I also changed 'state-icon-active-color' to the same choice, restarted HA and all is well. I'm not sure which one of those variables actually changed it since I did both, but it's working well for me now.

could you explain more precisely which lines you changed?

asteroidz commented 2 years ago

@waring86 The theme use css variables. For state color it use "paper-item-icon-color" which is defined by another variable "state-icon-active-color" which is again defined in kibibit(normal and dark) by white color (#fff).

To fix the state color problem you need to edit the theme yaml(/config/themes/kibibit/kibibit.yaml) find the line where is defined "state-icon-active-color" and add a "#" at the start of the line to comment it, then restart your HA, it will take the default variables from HA Core theme and restore active state color in icon as normal.

image image image

it will keep the color of led as well ;) image

waring86 commented 2 years ago

thanks, its working ;)