Kickflip / kickflip-android-sdk

Kickflip Android SDK - Live Video Streaming to the Cloud
https://kickflip.io
Apache License 2.0
658 stars 212 forks source link

Rejected from Google due to OpenSSL version issue. #57

Closed inturbidus closed 8 years ago

inturbidus commented 8 years ago

I believe this is from FFMPEGs use of OpenSSL. Can it be upgraded to 1.0.1h, 1.0.0m, or 0.9.8za?

chrisballinger commented 8 years ago

Yes there should be no issue with upgrading the OpenSSL libraries

On Wed, Jun 29, 2016 at 1:23 PM, Matt Hudson notifications@github.com wrote:

I believe this is from FFMPEGs use of OpenSSL. Can it be upgraded to 1.0.1h, 1.0.0m, or 0.9.8za?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kickflip/kickflip-android-sdk/issues/57, or mute the thread https://github.com/notifications/unsubscribe/AAfqHxaIeiZ1KYCNN_6tPvQULPnhsBsTks5qQtQogaJpZM4JBhzV .

inturbidus commented 8 years ago

Here's what they said https://support.google.com/faqs/answer/6376725?hl=en

inturbidus commented 8 years ago

Can you help with this or point me in the right direction?

OnlyInAmerica commented 8 years ago

Thanks for the report! I'll see if I can fix this tomorrow, and add clearer instructions for future upgrades.

On Fri, Jul 1, 2016, 11:51 AM Matt Hudson notifications@github.com wrote:

Can you help with this or point me in the right direction?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kickflip/kickflip-android-sdk/issues/57#issuecomment-230021865, or mute the thread https://github.com/notifications/unsubscribe/AAb_DifPz8iUNmjNK3y5sgDmtrAxn_-fks5qRWGXgaJpZM4JBhzV .

OnlyInAmerica commented 8 years ago

I've updated FFmpeg to 2.8.7 (3.X will require changes to the JNI Bridge) and removed OpenSSL since that was only used for RTMP support which has been removed from this project. You can trial the changes in the ffmpeg287 branch. Currently just the arm shared libraries are included. If you have success I'll merge #58 and release the update.

To make updating FFmpeg and the JNI bridge easier I've moved the bridge into this project directly, and added more complete instructions to DEVELOPMENT.md. In short:

To update FFmpeg in the future:

  1. Build FFmpeg shared libraries (instructions) and copy the libav* shared libraries to ./src/main/jni/ffmpeg/ARCH and their headers to ./src/main/jni/include
  2. Update the JNI bridge at ./src/main/jni/FFmpegWrapper.c if necessary (FFmpeg 3.x)
  3. Invoke ndk-build from ./src/main/jni.
inturbidus commented 8 years ago

Great! Appreciated! I'll test it out and reply.

inturbidus commented 8 years ago

Resolved. Thank you.