Kicktemp / kickgdpr

Please visit our new Onlineshop
https://kicktemp.shop/plugins/11/kickgdpr-gdpr/dsgvo-cookie-system-plugin-fuer-joomla
GNU General Public License v3.0
5 stars 1 forks source link

kickgdpr_ga_optout tag in articles #6

Open pulsarinformatique opened 5 years ago

pulsarinformatique commented 5 years ago

Hi

Even if I put

{kickgdpr_ga_optout}Disable Google Analytics{/kickgdpr_ga_optout}

in the legal notices article it only displays the tags without interpretating it

However I find this behaviour normal since there is no content plugin (only a system plugin)

How do you intend it to mahe it work please ?

Thanks

cyril

tecpromotion commented 5 years ago

Hi @pulsarinformatique A system plugin always works. https://docs.joomla.org/Plugin/Events/System No content plugin needed.

Is your legal notice a normal Joomla! item?

pulsarinformatique commented 5 years ago

Not, it is a seblod content but the system seblod plugin is always the first one so that all the content plugins are processed correctly after

Seblod content are joomla extended contents (same #__content table plus additional tables)

tecpromotion commented 5 years ago

Does the {loadmodule} in a seblod article work for you?

pulsarinformatique commented 5 years ago

Yes, just checked again but {kickgdpr_ga_optout}Disable Google Analytics{/kickgdpr_ga_optout} doesn't

cyril

pulsarinformatique commented 5 years ago

Theorically you do need to have a content plugin to interpret the {} tags in articles. This is the standard joomla way. If you only have a system plugin it is normal you have cases that break

thanks

cyril

nielsnuebel commented 5 years ago

@pulsarinformatique thanks for the note but that's not correct.

system plugins are always executed after initializing joomla https://github.com/joomla/joomla-cms/blob/d3fb98cb9ba20a6e03b78ba7ee269b336c04862f/libraries/src/Application/CMSApplication.php#L622

https://github.com/joomla/joomla-cms/blob/d3fb98cb9ba20a6e03b78ba7ee269b336c04862f/components/com_content/views/article/view.html.php#L193

System Plugins are always triggered image

debug

Maybe Seblod grab introtext and not text.

pulsarinformatique commented 5 years ago

yes the problem is that SEBLOD puts stuff in the introtext and uses a special CONTENT plugin (that should be the first on the list) to hide his own stuff.

in our example, if I deactivate the seblod content plugin your system plugin works but of course I can't deactivate the seblod content plugin :(

So far we never faced such a problem because all third party extensions that put some {} tags in the article used content plugins and not system plugins.

thanks