search

Kide-Devs / Kide

#hacktoberfest A KIIT Guide - KIDE is an app for all you university related needs! This app is developed with the plan of making it the one app to rule them all. From guiding new visitors, to seeing all the student activities presently taking place, upto student attendance tracking, All within a single easy to use app made with the power of Flutter.
24 stars 25 forks source link

Aspect Ratio of Images on PostCards dont align with the size of the box #22

Closed Cryptonex7 closed 4 years ago

Cryptonex7 commented 4 years ago

Description

Aspect Ratio of Images on PostCards don't align with the size of the box - which creates an empty gray space in above and below the image.

Potential Solution

Add the same image behind the actual image and enlarge it to cover the entire box and blur the image. Just like this : https://www.google.com/url?sa=i&url=https%3A%2F%2Fwww.socialmediaexaminer.com%2F8-apps-instagram-stories%2F&psig=AOvVaw1btnhgO8Y8M2z9lWrj0cB-&ust=1601713926516000&source=images&cd=vfe&ved=0CAIQjRxqFwoTCKDRyMa_lewCFQAAAAAdAAAAABAG

Supporting Images

Screenshot_20201002-133912

emem365 commented 4 years ago

Add the same image behind the actual image and enlarge it to cover the entire box and blur the image.

Are you sure you dont just want the image to "Fill" the container? A small part of the image would be cut off but it would look a lot more clean. Either way, could I maybe take up this issue and try fixing it for you?

Would like to hear your thoughts about the fill solution

Cryptonex7 commented 4 years ago

Well, if you could do a normal fill - while keeping the existing features of loading animations and placeholders intact, then you could surely do that.

However, if for any reason you cannot achieve a "Fill", then you could go with the proposed solution.

Thanks @emem365 for your attempt - we would be awaiting your PR.

Happy HacktoberFest. :)

emem365 commented 4 years ago

Created a PR #34 to fix the issue. Have a look and merge if you find it sufficient. happy to help :)

Cryptonex7 commented 4 years ago

Sure @emem365 , we will make sure your PR gets reviewed within 7 days. Thanks for contributing to KIDE.

We have more such issues coming up tomorrow - do check back to find more issues in your interest.

Regards, Cryptonex7

Cryptonex7 commented 4 years ago

Meanwhile, @emem365 , we have listed new issues for Hacktoberfest - you might want to go and check them out as well.