"Help and feedback" & "Privacy Policy" Buttons inside settings not working.

Kide-Devs / Kide

#hacktoberfest A KIIT Guide - KIDE is an app for all you university related needs! This app is developed with the plan of making it the one app to rule them all. From guiding new visitors, to seeing all the student activities presently taking place, upto student attendance tracking, All within a single easy to use app made with the power of Flutter.

24 stars 25 forks source link

"Help and feedback" & "Privacy Policy" Buttons inside settings not working. #24

Closed Cryptonex7 closed 4 years ago

Cryptonex7 commented 4 years ago

Description

The Help & Feedback feature is there on the side drawer - which is functional. However, the same button in the settings Page is not working.
And the Privacy policy button is totally non-functional.

Potential Solution

Copy the action that happens on pressing the Help and Feedback Button from the side drawer to the one in the settings page.
Remove the Privacy Policy Button (We dont have it ready yet - we will add it once we are done with the policy).

Supporting Images

Screenshot_20201002-141200

anirudhbagri commented 4 years ago

I don't see any action on "Help and Feedback" in the drawer button.

emem365 commented 4 years ago

@anirudhbagri I was gonna take up this issue myself but since you're already on it. Check out lines 227-267 in pages/HomePage/Home.dart

                      ListTile(
                        leading: Icon(Icons.help),
                        title: Text('Help and Feedback'),
                        onTap: () {
                          showDialog(
                            context: context,
                            builder: (context) => AlertDialog(
                             ... //Some More code
                          );
                        },
                      ),

Just copy paste the whole thing or maybe you can declare the AlertDialog as a seperate widget and use it in both the places. Good Luck :)

Cryptonex7 commented 4 years ago

@emem365 Thanks for helping @anirudhbagri out. This is an open issue and both of you can attempt the PR for this issue.

Ayushi673 commented 4 years ago

Hi @Cryptonex7, since this is an open issue I've worked on it an I'm trying for a PR. Please have a look. I will make further improvements if required.

Cryptonex7 commented 4 years ago

Sure @Ayushi673 , we will make sure your PR gets reviewed within 7 days. Thanks for contributing to KIDE.

We have more such issues coming up tomorrow - do check back to find more issues in your interest.

Regards, Cryptonex7

Cryptonex7 commented 4 years ago

Meanwhile, @anirudhbagri, @Ayushi673, @emem365 , we have listed new issues for Hacktoberfest - you might want to go and check them out as well.