Kide-Devs / Kide

#hacktoberfest A KIIT Guide - KIDE is an app for all you university related needs! This app is developed with the plan of making it the one app to rule them all. From guiding new visitors, to seeing all the student activities presently taking place, upto student attendance tracking, All within a single easy to use app made with the power of Flutter.
24 stars 25 forks source link

Avatar editor ui revamp #44

Closed jordanmlacalle closed 4 years ago

jordanmlacalle commented 4 years ago

Candidate PR to update Avatar Editor UI per issue #40 .

This PR reworks the Avatar Editor UI to align it more with the rest of the app. It also adds a custom RoundedButton that can be used to reduce code duplication. This button could be dropped into profile.dart and EditProfile.dart to reduce the duplicated code of those buttons while providing a consistent UX/UI.

Cryptonex7 commented 4 years ago

Also, @jordanmlacalle, extremely sorry for the delay in our response - we had so many PRs to review in more of our associated Open sourced projects of KIDE.

We are sorry for the inconvenience caused, we are trying our best to do justice to each and every contribution. Thanks for your patience.

jordanmlacalle commented 4 years ago

@Cryptonex7 Thank you for the feedback! I'll revisit this later today and make changes accordingly.

vanshBhatia-A4k9 commented 4 years ago

Firstly, @jordanmlacalle , Thanks a lot for contributing to this project! We've tested your PR and it's almost ready to be merged, we had a few minor suggestions that we'd be grateful if you could change. I've added the screenshots and a brief description of the changes requested below for visualization purposes:

WhatsApp Image 2020-10-11 at 5 31 06 PM

WhatsApp Image 2020-10-11 at 5 31 20 PM

WhatsApp Image 2020-10-11 at 5 32 27 PM

Once again, thanks for contributing to this project, hoping to hear back from you soon!

Cryptonex7 commented 4 years ago

@jordanmlacalle,

Thanks, we will be awaiting your changes with a lot of excitement. Please note - if this goes well you will receive a certificate from the team KIDE, acknowledging your contribution - as this particular issue is a significant change to our project!

jordanmlacalle commented 4 years ago

@Cryptonex7 , @A4k9

Thanks for the details! I'm starting to look back at this now and throughout the day. I'll do my best with the spacing between the avatar and editor, but unfortunately the extra spacing above the avatar is actually part of the SVG image. I think moving the save button the the AppBar as you suggested should alleviate some of the crowding.

Cryptonex7 commented 4 years ago

Sure @jordanmlacalle, if that is the case, please do whatever best is possible in terms of optimizing the space.

jordanmlacalle commented 4 years ago

@Cryptonex7 Pushed some changes.

Some screenshots below:

Screenshot_20201012-162312 Screenshot_20201012-162352

One thought for another issue is that the Avatar does not update throughout the app after saving. Fixing this might require keeping some global state of the avatar properties and updating this on press of the "Save" button as well. Could be a usecase for some state management like Provider + ChangeNotifier, etc. But best logged as a separate issue.

Let me know any other feedback you have or design / feature you might want in the editor!

Thanks

Cryptonex7 commented 4 years ago

Hey @jordanmlacalle - thanks for the fixes. We will soon review this. Sorry for the delay. We are a team based in India - so there will be a 12 hour time lag between our communications :)

We will keep you posted about these changes - and soon send you the review.

Rest assured - the entire team is very excited about this particular PR.

Thanks

Cryptonex7 commented 4 years ago

Hey @jordanmlacalle, things look good here - can you just make the save button a bit smaller, and maybe reduce the padding in the button?

jordanmlacalle commented 4 years ago

@Cryptonex7 , @A4k9 Made some minor adjustments, here's a new screenshot:

image

Sorry for the time between these changes!

vanshBhatia-A4k9 commented 4 years ago

@Cryptonex7 Please review.

vanshBhatia-A4k9 commented 4 years ago

@jordanmlacalle, we will soon be giving you a certificate acknowledging all your work towards our project, please accept it as a sign of gratitude from team KIDE for choosing to invest your precious time into helping us with this issue. 👍 🥇

Cryptonex7 commented 4 years ago

Congratulations @jordanmlacalle

Your PR has really been of significant importance for team KIDE. Therefore, We would like to acknowledge you efforts through this certificate.

Feel free to upload this on LinkedIn or any social media - and if you do that, also link our repository with it so that we could get more such awesome contributions from people like you.

We are also looking forward to have you contribute more to KIDE. Please consider recontributing to more of our listed issues.

Thanks and Regards, Team Kide.

Jordan Moreno-Lacalle