search

Kidfund / building.kid.fund

Kidfund's Design & Engineering blog
http://building.kid.fund/
Other
1 stars 2 forks source link

Writing a good pull request #25

Open mrh-is opened 6 years ago

mrh-is commented 6 years ago

What goes into a good PR description?

  1. The problem
    • The bad behavior
    • Context of of when/how/why/who/etc the behavior occurs (if relevant)
    • The mechanism of the bad behavior
    • Why that behavior is wrong (if not obvious)
  2. The fix
    • The new, correct behavior
    • Why this behavior is the right behavior (if not obvious)
    • How the fix works
  3. Testing
    • How to test
    • What to look for
mrh-is commented 6 years ago

Use a PR template on GitHub to automate