Scale bug take 2

[redvex]

I've update KLNoteViewController on my project with the last version (Bug fixed for https://github.com/KieranLafferty/KLNoteViewController/pull/16).

It's pixel perfect on portrait, it's still buggy on landscape: ~140px from status bar to first view bar ~190px from status bar to first view bar

This is my conf: #define kDefaultMinimizedScalingFactor 1.00

define kDefaultMaximizedScalingFactor 1.00

define kDefaultNavigationBarOverlap 0.90

define kDefaultAnimationDuration 0.3

define kDefaultReloadHideAnimationDuration 0.4

define kDefaultReloadShowAnimationDuration 0.6

#define kDefaultVerticalOrigin 250

define kDefaultCornerRadius 5.0

define kDefaultShadowEnabled YES

define kDefaultShadowColor [UIColor blackColor]

define kDefaultShadowOffset CGSizeMake(0, -5)

define kDefaultShadowRadius kDefaultCornerRadius

define kDefaultShadowOpacity 0.60

define kDefaultMinimumPressDuration 0.2

With default values this issue is still present (only in landscape) but is less visible even if after some rotation some defects are still present:

That's all :)

[KieranLafferty]

Hey Redvex, thanks for bringing this up. Currently this control is only supported in portrait orientation (see README). It is clear that this should be adapted to work on landscape as well, but at the moment I have been short on time to implement this fix.

Keep the bug reports coming though, very much appreciated :)

[chintan100]

Hi,

I am able to reproduce this issue in portrait on iPhone 4S running iOS 6.1.3.

Let me know if you are working on this fix now or can guide me in right direction. It is very difficult to reproduce but random taps and pans makes it happen sometimes.

[KieranLafferty]

Hey Chintan,

I have seen several reports of this type of behaviour, however for all cases reported thus far have had to do with people using it for both portrait and landscape where the action of turning from one to the other (portrait -> landscape and vice versa) is causing this issue. As mentioned in the readme this control supports only portrait, meaning that if your app allows for orientation changes then it will immediately mess with the control in unexpected ways. I will close this for now but feel free to let me know if you are getting this behaviour with only portrait mode enabled

[chintan100]

Yes, disabling landscape orientations does fix the issue. Thank you for this control and keep up the good work!

[raheelahmad786]

@chintan100 How did you disable the landscape orientation in KNoteViewController ? Can you please mention ?

Thanks.

[chintan100]

I don't remember since it was a while back but i think i just disabled landscape orientation from Target settings in Xcode.