search

KieranWynn / pyquaternion

A fully featured, pythonic library for representing and using quaternions
http://kieranwynn.github.io/pyquaternion/
MIT License
339 stars 68 forks source link

add eulers angles #38

Open mgoacolou opened 5 years ago

mgoacolou commented 5 years ago

add method to retreive euler angle with convention as parameter

KieranWynn commented 4 years ago

Thanks for the PR @mgoacolou

After taking a look, I like what you're doing. Is there a reason you've used the matrix form as an intermediate representation? I'd rather not have to go through the extra conversion step if possible as it compounds any errors in the conversions or bugs in the code.

After a quick google, it seems there may be some resources for converting directly between quaternion form and Euler angles see https://math.stackexchange.com/a/693368 Unfortunately, this only defines operations for the z-x-z and z-y-x conventions.

My preference would be to implement at least those two conventions via direct conversion from quaternion form and leave it open to being extended for additional conventions via future PRs

fabrizioschiano commented 3 years ago

Do you plan to merge this into master anytime soon? Or, is there another way to convert from quaternions to Euler angles?

mikepianka commented 2 years ago

Is this PR ready to go, just waiting to be rolled into the 1.0 release?

davidfufu commented 1 year ago

Any updates on this? Would love euler angle support.

warenick commented 10 months ago

Any updates there? Why this PR can't merge 4 years?