search

KieronQuinn / AmbientMusicMod

Port of Now Playing from Pixels to other Android devices
GNU General Public License v3.0
1.87k stars 41 forks source link

GitHub tag confusing in-app updater #171

Closed Mikrz closed 1 year ago

Mikrz commented 1 year ago

It looks like the GitHub tag is set to "220" instead of "2.2.0" unlike previous releases, causing the app to think it's out of date. See below screenshot:

Screenshot_20230418_194500_Ambient Music Mod.png

KieronQuinn commented 1 year ago

Oops, forgot I was using tags not version codes on this one. Fixed.

Mikrz commented 1 year ago

Oops, forgot I was using tags not version codes on this one. Fixed.

Can confirm, that fixed it for Ambient Music Mod.

Could be a cache thing (though the AmbientMusicMod updater entry refreshed immediately) but the Now Playing updater entry isn't recognizing that it is out of date. I can probably manually update it without issue, but figured I should mention that to you as well.

Alternatively, perhaps it relies on the music db in which case I just haven't waited long enough. 😉

KieronQuinn commented 1 year ago

Clear the cache of Ambient Music Mod, that unclogs it. Not sure why it was doing it in the first place, swipe refreshing is supposed to ignore the cache.

Mikrz commented 1 year ago

Yeah, actually oddly enough Now Playing registers as being out-of-date when manually updated to 1.2, showing 1.1.1 as the newer version... 🤔

Screenshot_20230418_200440_Ambient Music Mod.png

Mikrz commented 1 year ago

Huh, clearing cache fixed that. Very odd behaviour.

KieronQuinn commented 1 year ago

Found it, this line is misbehaving and telling it to skip the local version rather than the cache. Damned default arguments.

Will push a .1 release fixing that and suppressing the widget crash issue that was opened right as I was uploading

Mikrz commented 1 year ago

Thanks for your quick work! 😁 I use this app all the time so it's awesome to see such rapid work, even for an issue that's so easy to work around such as this (less so the widget issue I guess though, hah).