search

KieronQuinn / AmbientMusicMod

Port of Now Playing from Pixels to other Android devices
GNU General Public License v3.0
1.87k stars 41 forks source link

On-Demand recognition is ONLY marked unavailable in the recognition dialog #174

Closed ralph950412 closed 1 year ago

ralph950412 commented 1 year ago

As the title described, On-Demand is marked unavailable in the recognition dialog, but not in the settings; it should've been notified in the latter one in the first place.

Below is what I see in the settings.

Screenshot_20230419-163201

ralph950412 commented 1 year ago

Meanwhile, this is what's shown in the recognition dialog.

Screenshot_20230419-163713

KieronQuinn commented 1 year ago

This isn't a new issue, it's been raised before and seems to happen only on some specific devices. I'll probably see if I can update my OP7TP to the dreaded Oxygen OS 12 build temporarily to see if that can trigger it.

ralph950412 commented 1 year ago

This isn't a new issue, it's been raised before and seems to happen only on some specific devices. I'll probably see if I can update my OP7TP to the dreaded Oxygen OS 12 build temporarily to see if that can trigger it.

I see... Looking forward to it! Although in my case it's just one specific custom ROM I built recently...

KieronQuinn commented 1 year ago

Installed Oxygen 12 on it, works fine with both Shizuku as root and Sui. What device and ROM is this and are you using Shizuku as root or Sui?

ralph950412 commented 1 year ago

I use Shizuku as root, and the device is a Mi 11. ROM info: Screenshot_20230420-082436 (P.S. The Google app seems to have the split_sound_search_fingerprinter_split.apk)

KieronQuinn commented 1 year ago

Can you try with Sui maybe? It should behave the same, but it would be interesting to know if it does not.

KieronQuinn commented 1 year ago

You can also try this build (zipped), it may fix it. If you still see a service error, then the issue is genuine and can't be resolved.

app-release.zip

ralph950412 commented 1 year ago

Can you try with Sui maybe? It should behave the same, but it would be interesting to know if it does not.

What the... It's working with SUI! I wonder why Shizuku didn't work.. Screenshot_20230420-092635

KieronQuinn commented 1 year ago

Ok, could you try reverting to Shizuku (sorry!) and that build? I want to make it as compatible as possible ideally.

ralph950412 commented 1 year ago

Ok, could you try reverting to Shizuku (sorry!) and that build? I want to make it as compatible as possible ideally.

Sure 👍

ralph950412 commented 1 year ago

You can also try this build (zipped), it may fix it. If you still see a service error, then the issue is genuine and can't be resolved.

app-release.zip

Sorry for the late reply, but this works with both Shizuku and Sui!

Update: Using the Shizuku method sometimes reports service error, just like what you've said Ig I'll stick to Sui

KieronQuinn commented 1 year ago

Excellent, thanks. Only detriment of the change I made is it would throw an error even later if there's a genuine problem (which should be very rare with it), so I'll get that in a release soon.

Thanks again for your help!

ralph950412 commented 1 year ago

Excellent, thanks. Only detriment of the change I made is it would throw an error even later if there's a genuine problem (which should be very rare with it), so I'll get that in a release soon.

Thanks again for your help!

No problem, thanks :)

KieronQuinn commented 1 year ago

Fixed in 2.2.2

enzalito commented 1 year ago

@KieronQuinn I'm experiencing the same issue on version 2.3.1 of the app. I'm using Shizuku on a device that is not rooted

KieronQuinn commented 1 year ago

@KieronQuinn I'm experiencing the same issue on version 2.3.1 of the app. I'm using Shizuku on a device that is not rooted

This is the intended behaviour as stated above. The original setup worked around this but introduced this issue, the workaround has the side effect of what you are describing.