search

KieronQuinn / AmbientMusicMod

Port of Now Playing from Pixels to other Android devices
GNU General Public License v3.0
1.86k stars 41 forks source link

Music is filtered out by NC #24

Closed incapable closed 3 years ago

incapable commented 3 years ago

When listening to musing, 99% of the music appears to be filtered out when testing with the "test recognition" feature. I've tried tweaking with amplification but it makes no difference. Screenshot_20210520-175343 Music input sample log dump

incapable commented 3 years ago

Some additional info i forgot to mention: Phone: oneplus 8 pro OS: oxygenos/android 12, european version, 2021-03-01 patch Xposed framework: EdXposed 4.6.2 Magisk: 23 ambient music mod: 1.1

KieronQuinn commented 3 years ago

Ah thanks for the sample. It does seem to be being filtered out by something, rather than just the normal as I said it could've been on XDA.

There's nothing I can really do about this though unfortunately, there's no noise cancellation applied by the app or the mod, so anything that is happening must be coming from the system and I can't turn that off as it'll be native.

incapable commented 3 years ago

I understand, but the reason that I asked is because I hoped there might be a secondary virtual audio device, or a parameter, that simply listens to the raw microphone stream. But I guess that's too system specific?

KieronQuinn commented 3 years ago

There is, but that would make the audio recording the same as a standard sound recording app, which it's not designed for and I don't even know if it would work. It uses the assistant audio stream type, which seamlessly handles other apps using the microphone, internal audio from the phone, disabling during calls etc. Unfortunately as that type is designed for speech, it's not ideal for detecting music on some devices.

incapable commented 3 years ago

Hmm I understand, I'll just have a look through your codebase then and will tinker a bit, see if I can get a result that works 🙂 I feel like it could be a less then ideal workaround for situations as mine