search

KieronQuinn / Smartspacer

Smartspacer is a customisable widget for Android, but with a difference: It can upgrade the built in At a Glance on Pixels - without root!
GNU General Public License v3.0
1.96k stars 42 forks source link

[Bug] Plugins: Installed tab should only display installed plugins #3

Closed yochananmarqos closed 10 months ago

yochananmarqos commented 10 months ago

Description

Before installing any plugins, the Installed and Available results are identical. I installed the Aftership and Amazon plugin. They do only appear on the Installed section now, however all the rest of the plugins still appear in the Installed section.

Smartspaces 1.1 Pixel 8 Android 14

KieronQuinn commented 10 months ago

This is intentional, the "Available" tab lists all remaining plugins which are not installed, the "Installed" tab is just those you have installed. You get the same functionality in terms of being shown which have updates on either tab.

yochananmarqos commented 10 months ago

I think you may be misunderstanding. I don't know how I can be more clear with words, so I'll show you:

Screenshot_20231024-162421

Screenshot_20231024-162451

KieronQuinn commented 10 months ago

Ok, my explanation was wrong, but the app is functioning as intended

The Installed tab is all plugins, prioritising those which have updates. The Available tab is just plugins which are not already installed.

It was done this way so you can quickly see those which you haven't installed (the Available tab), and also see all of them including those already installed (the Installed tab)

yochananmarqos commented 10 months ago

Sorry, that's not logical. Maybe label things a little more clearly as you're intending.

In my perspective, it's simple:

Installed means installed. Why would plugins that are not installed be there?

Available would mean plugins that are available which are not installed.

KieronQuinn commented 10 months ago

The tab name could perhaps be clearer, maybe "All" would be better.

yochananmarqos commented 10 months ago

No, really. How am I supposed to know which plugins I have installed if other plugins are listed in the installed section that are not installed?

I just don't understand why we aren't seeing this eye to eye.

You're an awesome developer and I probably have used every app you've created over the years. I can't think of anything I've had an issue with with any other of your apps, so I'm sure you'll iron it all out.

KieronQuinn commented 10 months ago

Fair point. I'll reopen.

KieronQuinn commented 10 months ago

Fixed in 1.1.1

yochananmarqos commented 10 months ago

Thanks! :tada: