Kilian / Trimage

A cross-platform tool for optimizing PNG and JPG files.
http://trimage.org
MIT License
706 stars 55 forks source link

doesn't start with latest pngcrush #45

Closed ikn closed 7 years ago

ikn commented 7 years ago

After upgrading pngcrush from 1.8.11 to 1.8.12, Trimage fails to start. This happens with both 1.0.5 and the current git version (I'm using the packages in AUR).

$ trimage 
 pngcrush 1.8.12, uses libpng 1.6.31 and zlib 1.2.11
 Check http://pmt.sf.net/
 for the most recent version.

usage: pngcrush [options except for -e -d] infile.png outfile.png
       pngcrush -e ext [other options] file.png ...
       pngcrush -d dir/ [other options] file.png ...
       pngcrush -ow [other options] file.png [tempfile.png]
       pngcrush -h or -v -v -h (for help or verbose help) 
       pngcrush -n -v file.png ... (to list chunks)
[error] please install pngcrush
ghost commented 7 years ago

Same error here :(

Kilian commented 7 years ago

I think the return code for the pngcrush version check has changed. I emailed author for more information. I'm on Ubuntu 16.04 myself which still has 1.7.85 so haven't encountered this myself.

glennrp commented 7 years ago

I'm not sure but will investigate. I'm planning to release 1.8.13 soon with some changes in this area.

Kilian commented 7 years ago

@ikn @JoZ3 pngcrush 1.8.13 was just released by @glennrp (so fast!) can you see if the issue is now resolved? https://sourceforge.net/projects/pmt/files/pngcrush/

ghost commented 7 years ago

@Kilian yes works for me. And thanks so much @glennrp

Kilian commented 7 years ago

whoo! :100: :tada:

ikn commented 7 years ago

Yeah, same here, works fine.

Kilian commented 7 years ago

nice, closing this!