Kilian / f.lux-indicator-applet

This repository is unmaintained. Visit:
https://github.com/xflux-gui/xflux-gui
Other
549 stars 105 forks source link

New version of xflux. #29

Closed d7415 closed 10 years ago

d7415 commented 10 years ago

Signed-off-by: Martin Stone martin@d7415.co.uk

jhasse commented 10 years ago

This works fine! Is Kilian still active?

madrob commented 10 years ago

Can this please be merged? The bundled version of xflux did not work for me on Saucy Salamander (Ubuntu 13.10) and I had to manually download this binary to resolve the issue.

Kilian commented 10 years ago

I'm hesitant to accept unchecked binaries. Is this the latest xflux downloaded from http://justgetflux.com/ ?

madrob commented 10 years ago

Feel free to verify yourself, but it certainly appears to be.

mdrob@mdrob-W530:~/workspace/f.lux-indicator-applet$ wget https://justgetflux.com/linux/xflux64.tgz -O- | tar xz -O | openssl sha1
(stdin)= f43d7118d9445f7df05f91d435feed4179e77e42
mdrob@mdrob-W530:~/workspace/f.lux-indicator-applet$ git checkout upstream/pr/29
HEAD is now at ba86838... New version of xflux.
mdrob@mdrob-W530:~/workspace/f.lux-indicator-applet$ openssl sha1 ./xflux
SHA1(./xflux)= f43d7118d9445f7df05f91d435feed4179e77e42
mdrob@mdrob-W530:~/workspace/f.lux-indicator-applet$ wget https://justgetflux.com/linux/xflux64.tgz -O- | tar xz -O | wc -c
706004
mdrob@mdrob-W530:~/workspace/f.lux-indicator-applet$ wc -c xflux 
706004 xflux

I'm not saying that a dedicated attacker wouldn't be able to create a collision, in which case you should get the binary from the site, but having the correct binary from any source would be useful.

d7415 commented 10 years ago

Yup. Well, it was the latest when I downloaded it and it was from there.

If you're unsure you could replace it yourself and just close this request? Or have the app get the latest / point the user at the latest version / add "xflux" as a requirement to be installed first.

tripflex commented 10 years ago

Yeah PPA from site does not work on ubuntu, mint, etc...only thing that works is xflux...but anybody who doesn't know much about linux would probably just give up

Kilian commented 10 years ago

Latest version has been added :)