search

Kilian / fromscratch

Autosaving Scratchpad. A simple but smart note-taking app
https://fromscratch.rocks
MIT License
718 stars 62 forks source link

Feature request: Theming/colors #6

Open JohnSandel opened 8 years ago

JohnSandel commented 8 years ago

FromScratch is a lovely piece of work. Thank you!

I'd find it more useful if text & background colors were user-definable. As is, I find the text harder to use than, say, black-on-white.

adiultra commented 8 years ago

Yep I do like the solarised light syntax theme rather than solarised dark. Also, It would be great to have custom font, because I am a real fan of Architects Daughter Font, for note taking.

@JohnSandel pls change the issue title to themeing ;p

Kilian commented 8 years ago

Would a settings/theming file in ~/.fromscratch suffice? a theme.json with this style?

{
  "background":"#000",
  "color": "#fff"
}
adiultra commented 8 years ago

@Kilian Yep It would definetly, But gui would be great for non programmers. :+1:

Kilian commented 8 years ago

FromScratch currently has no management gui or settings, and I'd like to keep it that way.

adiultra commented 8 years ago

:cry: :crying_cat_face:

spike1234 commented 8 years ago

+1

Kilian commented 8 years ago

I'm going to wait until electron updates to Chrome 48 or 49 so I can try and use css variables. Due to the theme now using SCSS to programmaticly define the highlight and focus colors based off the default colors, this is harder to do on runtime.

altern8tif commented 7 years ago

Is this still on the cards?

Kilian commented 7 years ago

Yes, but it turned out to be a bit more difficult than just setting the foreground and background :) I need a bunch of color functions to generate all the permutations (selection, found items, current line highlight) and that is currently done in SCSS. I could switch to CSS4 color functions and use PostCSS, but I would need to ship the parser and build something to parse a users css file with Fromscratch if end users should be able to theme. It's a difficult problem if you want to keep the automation for the styling that I have.

Another option is hue-rotate, which is very limited and basically only allows you to change the blue-ish tint to a different coloured tint, leaving the saturation and lightness the same (so you could have a dark theme in red, or green, or purple or whatever, but they would still be dark).

I'm holding out for a better option, or css4 color function support.

Kilian commented 7 years ago

It's a little work-in-progress, but I came up with a nice way to get a light theme: selection_003

This allows me to re-use my theme setup, as it's essentially a color-corrected inversion :)

spike1234 commented 7 years ago

very nice! I like it better than the standard colors! :)